Skip to content

Commit

Permalink
Remove duplicated checkinit on git module (#28824) (#28831)
Browse files Browse the repository at this point in the history
Backport #28824 by @lunny

`checkInit` has been invoked in `InitSimple`. So it's unnecessary to
invoke it twice in `InitFull`.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
  • Loading branch information
GiteaBot and lunny authored Jan 17, 2024
1 parent 8b4abb1 commit 8b5c918
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions modules/git/git.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,6 @@ func InitSimple(ctx context.Context) error {
// InitFull initializes git module with version check and change global variables, sync gitconfig.
// It should only be called once at the beginning of the program initialization (TestMain/GlobalInitInstalled) as this code makes unsynchronized changes to variables.
func InitFull(ctx context.Context) (err error) {
if err = checkInit(); err != nil {
return err
}

if err = InitSimple(ctx); err != nil {
return err
}
Expand Down

0 comments on commit 8b5c918

Please sign in to comment.