-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updating label for whitelist deploy keys force push
- Loading branch information
Henry Goodman
committed
Nov 16, 2023
1 parent
712b8c2
commit 99d45bd
Showing
2 changed files
with
29 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
NOTES: | ||
|
||
- The logic behind the box disabling/enabling is the class `toggle-target-enabled` with `data-target=#target-id` | ||
|
||
|
||
TODO: | ||
- In PR update UI, currently you can Update by merge | ||
- We need to keep this, but also allow Update by Rebase iff CanForcePush | ||
|
||
|
||
- Ensure logic is correct for saving | ||
- Saving the whitelist users/teams correctly DONE | ||
|
||
- Check rules is consistent DONE | ||
- Apply backend logic (look at how normal pushing is done currently) | ||
|
||
- Make sure format looks like on new rule creation DONE | ||
|
||
- Force push ALSO requires normal push DONE | ||
- Make it so option is disabled if regular push is also disabled | ||
|
||
|
||
- Check if API is updated at all (might need to update documentation) | ||
|
||
- Localise strings in template DONE for Eng | ||
|
||
repo.settings.protect_enable_force_push | ||
repo.settings.protect_enable_force_push_desc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters