as per 6543

Signed-off-by: Andrew Thornton <art27@cantab.net>
go-gitea · Aug 11, 2021 · a034c54 · a034c54
1 parent d44ef83
commit a034c54
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/services/auth/source/smtp/source_authenticate.go b/services/auth/source/smtp/source_authenticate.go
@@ -28,13 +28,14 @@ func (source *Source) Authenticate(user *models.User, login, password string) (*
 	}
 
 	var auth smtp.Auth
-	if source.Auth == PlainAuthentication {
+	switch source.Auth {
+	case PlainAuthentication:
 		auth = smtp.PlainAuth("", login, password, source.Host)
-	} else if source.Auth == LoginAuthentication {
+	case LoginAuthentication:
 		auth = &loginAuthenticator{login, password}
-	} else if source.Auth == CRAMMD5Authentication {
+	case CRAMMD5Authentication:
 		auth = smtp.CRAMMD5Auth(login, password)
-	} else {
+	default:
 		return nil, errors.New("unsupported SMTP auth type")
 	}