Skip to content

Commit

Permalink
Fix build errors on BSD (in BSDMakefile) (#27594)
Browse files Browse the repository at this point in the history
1. `make build` fails because `||` and `&&` have the same precedence in
sh/bash, so the `false` command always evaluated (leading to an error).

   ```
   + which gmake /usr/local/bin/gmake
   + false

   *** Failed target:  .BEGIN
*** Failed command: which "gmake" || printf "Error: GNU Make is
required!\n\n" 1>&2 && false
   *** Error code 1
   ```

2. When `GPREFIX` is set to an empty string with quotation marks,
`gmake` mistakenly thinks that it's a file name:

   ``` gmake: *** empty string invalid as file name.  Stop. ```
  • Loading branch information
sryze authored Oct 13, 2023
1 parent 532f166 commit cf74f5f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions BSDmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ GARGS = "--no-print-directory"

# The GNU convention is to use the lowercased `prefix` variable/macro to
# specify the installation directory. Humor them.
GPREFIX = ""
GPREFIX =
.if defined(PREFIX) && ! defined(prefix)
GPREFIX = 'prefix = "$(PREFIX)"'
.endif

.BEGIN: .SILENT
which $(GMAKE) || printf "Error: GNU Make is required!\n\n" 1>&2 && false
which $(GMAKE) || (printf "Error: GNU Make is required!\n\n" 1>&2 && false)

.PHONY: FRC
$(.TARGETS): FRC
Expand Down

0 comments on commit cf74f5f

Please sign in to comment.