Skip to content

Commit

Permalink
subscribers return []user.APIFormat
Browse files Browse the repository at this point in the history
  • Loading branch information
6543 committed Oct 29, 2019
1 parent 06daf4e commit deaf69c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 13 deletions.
6 changes: 0 additions & 6 deletions modules/structs/issue.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,3 @@ type EditPriorityOption struct {
// required:true
Priority int `json:"priority"`
}

// IssueWatchers list of subscribers of an issue
type IssueWatchers struct {
// required:true
Subscribers []string `json:"subscribers"`
}
2 changes: 1 addition & 1 deletion routers/api/v1/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ func RegisterRoutes(m *macaron.Macaron) {
m.Post("/stop", reqToken(), repo.StopIssueStopwatch)
})
m.Group("/subscriptions", func() {
m.Get("", reqToken(), bind(api.IssueWatchers{}), repo.GetIssueWatchers)
m.Get("", reqToken(), bind(api.User{}), repo.GetIssueWatchers)
m.Put("/:user", reqToken(), repo.AddIssueSubscription)
m.Delete("/:user", reqToken(), repo.DelIssueSubscription)
})
Expand Down
11 changes: 5 additions & 6 deletions routers/api/v1/repo/issue.go
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ func DelIssueSubscription(ctx *context.APIContext) {
}

// GetIssueWatchers return subscribers of an issue
func GetIssueWatchers(ctx *context.APIContext, form api.IssueWatchers) {
func GetIssueWatchers(ctx *context.APIContext, form api.User) {
// swagger:operation GET /repos/{owner}/{repo}/issues/{index}/subscriptions issue issueSubscriptions
// ---
// summary: Get users who subscribed on an issue.
Expand Down Expand Up @@ -785,21 +785,20 @@ func GetIssueWatchers(ctx *context.APIContext, form api.IssueWatchers) {
return
}

var subscribers []string

iw, err := models.GetIssueWatchers(issue.ID)
if err != nil {
ctx.Error(500, "GetIssueWatchers", err)
return
}

for _, s := range iw {
subscribers := make([]*api.User, len(iw))
for i, s := range iw {
user, err := models.GetUserByID(s.UserID)
if err != nil {
continue
}
subscribers = append(subscribers, user.LoginName)
subscribers[i] = user.APIFormat()
}

ctx.JSON(200, api.IssueWatchers{Subscribers: subscribers})
ctx.JSON(200, subscribers)
}

0 comments on commit deaf69c

Please sign in to comment.