Skip to content

Commit

Permalink
Do not use lower tag names to find releases/tags (#29261) (#29262)
Browse files Browse the repository at this point in the history
Backport #29261.

Fix #26090, see
#26090 (comment)

Since `TagName` stores the original tag name and `LowerTagName` stores
the lower tag name, it doesn't make sense to use lowercase tags as
`TagNames` in `FindReleasesOptions`.

https://github.com/go-gitea/gitea/blob/5e72526da4e915791f03af056890e16821bde052/services/repository/push.go#L396-L397

While the only other usage looks correct:

https://github.com/go-gitea/gitea/blob/5e72526da4e915791f03af056890e16821bde052/routers/web/repo/repo.go#L416
  • Loading branch information
wolfogre authored Feb 19, 2024
1 parent 39735c4 commit f79530c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions services/repository/push.go
Original file line number Diff line number Diff line change
Expand Up @@ -315,12 +315,7 @@ func pushUpdateAddTags(ctx context.Context, repo *repo_model.Repository, gitRepo
return nil
}

lowerTags := make([]string, 0, len(tags))
for _, tag := range tags {
lowerTags = append(lowerTags, strings.ToLower(tag))
}

releases, err := repo_model.GetReleasesByRepoIDAndNames(ctx, repo.ID, lowerTags)
releases, err := repo_model.GetReleasesByRepoIDAndNames(ctx, repo.ID, tags)
if err != nil {
return fmt.Errorf("GetReleasesByRepoIDAndNames: %w", err)
}
Expand All @@ -329,6 +324,11 @@ func pushUpdateAddTags(ctx context.Context, repo *repo_model.Repository, gitRepo
relMap[rel.LowerTagName] = rel
}

lowerTags := make([]string, 0, len(tags))
for _, tag := range tags {
lowerTags = append(lowerTags, strings.ToLower(tag))
}

newReleases := make([]*repo_model.Release, 0, len(lowerTags)-len(relMap))

emailToUser := make(map[string]*user_model.User)
Expand Down

0 comments on commit f79530c

Please sign in to comment.