Skip to content

Commit

Permalink
Skip known flaky queue tests on CI environment (#24419)
Browse files Browse the repository at this point in the history
Random CI failures are annoying. It's better to just skip the affected
tests so maintainers can use their valuable time for more productive
topics.

Related: #23608
Related: #23977
Related: #18703
  • Loading branch information
silverwind authored Apr 29, 2023
1 parent 9cf721e commit fc62992
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions modules/queue/queue_channel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package queue

import (
"os"
"sync"
"testing"
"time"
Expand Down Expand Up @@ -101,6 +102,9 @@ func TestChannelQueue_Batch(t *testing.T) {
}

func TestChannelQueue_Pause(t *testing.T) {
if os.Getenv("CI") != "" {
t.Skip("Skipping because test is flaky on CI")
}
lock := sync.Mutex{}
var queue Queue
var err error
Expand Down
5 changes: 5 additions & 0 deletions modules/queue/unique_queue_disk_channel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package queue

import (
"os"
"strconv"
"sync"
"testing"
Expand All @@ -15,6 +16,10 @@ import (
)

func TestPersistableChannelUniqueQueue(t *testing.T) {
if os.Getenv("CI") != "" {
t.Skip("Skipping because test is flaky on CI")
}

tmpDir := t.TempDir()
_ = log.NewLogger(1000, "console", "console", `{"level":"warn","stacktracelevel":"NONE","stderr":true}`)

Expand Down

0 comments on commit fc62992

Please sign in to comment.