Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Require Login for Specific Milestones #10312

Closed
bagasme opened this issue Feb 17, 2020 · 6 comments
Closed

Don't Require Login for Specific Milestones #10312

bagasme opened this issue Feb 17, 2020 · 6 comments
Labels
type/bug
Milestone
1.11.5

Comments

@bagasme
Copy link
Contributor

bagasme commented Feb 17, 2020

Description

From Discord:

Is it possible to configure Gitea so that Milestone pages don't require login? (for example, https://git.semicolin.games/semicolin/sneak/milestone/2 is a public repository, but you need to be logged in to see the milestone page.) It seems that by default, a not-logged-in user can see the /milestones page, and even which Issues are in which milestones, but not the page corresponding to a specific milestone.

Extend pages visible to non-logged-in users into specific milestone pages.
@bagasme bagasme changed the title Don't Require Login for Milestones Don't Require Login for Specific Milestones Feb 17, 2020
@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 17, 2020
@stale
Copy link

stale bot commented Apr 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 17, 2020
@guillep2k guillep2k mentioned this issue Apr 29, 2020
Closed
7 tasks
@kevans91
Copy link
Contributor

kevans91 commented Apr 29, 2020 •
edited
Loading

+1, this seems like a sensible change; I'll look at improving this if no one else is in the process of doing so.

@stale stale bot removed the issue/stale label Apr 29, 2020
@techknowlogick
Copy link
Member

techknowlogick commented Apr 29, 2020 •
edited
Loading

This is indeed sensible, however I think we should do it like github where the list of issues/PRs assigned to a milestone can be seen in the standard issues/PRs list page (ex. https://try.gitea.io/Etzelia/Test1/pulls?q=&type=all&state=open&labels=&milestone=893&assignee=0 )

@kevans91
Copy link
Contributor

This is indeed sensible, however I think we should do it like github where the list of issues/PRs assigned to a milestone can be seen in the standard issues/PRs list page (ex. https://try.gitea.io/Etzelia/Test1/pulls?q=&type=all&state=open&labels=&milestone=893&assignee=0 )

I'm afraid I'm being a bit dense here, I don't quite follow -- this example seems to already match github behavior, both allowing one to filter standard issues/PRs by milestone and displaying them in the subheading/metadata(?) area just below the title.

@techknowlogick
Copy link
Member

@kevans91 woops. I am the dense one. Please ignore my comment above.

@kevans91
Copy link
Contributor

kevans91 commented May 1, 2020

@techknowlogick OK, phew; :-)

kevans91 added a commit to kevans91/gitea that referenced this issue May 1, 2020
@kevans91
repo: milestone: make /milestone/:id endpoint accessible
eaa7890 
Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes issue go-gitea#10312, go-gitea#11233
@kevans91 kevans91 mentioned this issue May 1, 2020
Merged
@lunny lunny added this to the 1.11.5 milestone May 3, 2020
@lunny lunny added type/bug and removed type/enhancement An improvement of existing functionality labels May 3, 2020
kevans91 added a commit to kevans91/gitea that referenced this issue May 3, 2020
@kevans91
repo: milestone: make /milestone/:id endpoint accessible (go-gitea#11264
1cc029c 
)

Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes go-gitea#10312 
Fixes go-gitea#11233
@kevans91 kevans91 mentioned this issue May 3, 2020
Merged
lafriks pushed a commit that referenced this issue May 4, 2020
@kevans91 @guillep2k
repo: milestone: make /milestone/:id endpoint accessible (#11264) (#1…
5131206 
…1282)

Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes #10312 
Fixes #11233

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@kevans91
repo: milestone: make /milestone/:id endpoint accessible (go-gitea#11264
f5a0367 
)

Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes go-gitea#10312 
Fixes go-gitea#11233
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.11.5
Development

No branches or pull requests
4 participants
@lunny @techknowlogick @kevans91 @bagasme