[Bug] REPO_INDEXER doesn't index mirrored repository

[ghost]

• Gitea version (or commit ref): 1.11.4
• Git version: Not relevant
• Operating system: docker image
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist: Not relevant

Description

The REPO_INDEXER doesn't index the mirrored repository automatically. I have to remove the .bleve every time to start a new reindex for all repositories.

It would be great if the indexing can be triggered manually on a selected repository. Would be better if indexing is automatically triggered after pulling from remotes.

Screenshots

Here is my indexer configuration

[indexer]
ISSUE_INDEXER_PATH = /data/gitea/indexers/issues.bleve
REPO_INDEXER_ENABLED = true
REPO_INDEXER_PATH = /data/gitea/indexers/repos.bleve
UPDATE_BUFFER_LEN = 20
MAX_FILE_SIZE = 1048576
REPO_INDEXER_INCLUDE = 
REPO_INDEXER_EXCLUDE = resources/bin/**

[ghost]

Is it possible to call NotifyPushCommits manually form GUI, or via some command-line?

gitea/modules/notification/indexer/indexer.go

Line 126 in 310699b

func (r *indexerNotifier) NotifyPushCommits(pusher *models.User, repo *models.Repository, refName, oldCommitID, newCommitID string, commits *repository.PushCommits) {

Currently it is only called from repofiles/action.go, not for mirrored commits.

gitea/modules/repofiles/action.go

Line 257 in 6034f8b

notification.NotifyPushCommits(pusher, repo, opts.RefFullName, opts.OldCommitID, opts.NewCommitID, opts.Commits)

[ghost]

For mirrored commits, there is a NotifySyncPushCommits notification.

gitea/services/mirror/mirror.go

Line 412 in 2677d07

notification.NotifySyncPushCommits(m.Repo.MustOwner(), m.Repo, result.refName, oldCommitID, newCommitID, theCommits)

But the implementation seems to be missing in indexer/indexer.go.

There is only one for NotifyPushCommits, not for NotifySyncPushCommits

gitea/modules/notification/indexer/indexer.go

Line 126 in 310699b

func (r *indexerNotifier) NotifyPushCommits(pusher *models.User, repo *models.Repository, refName, oldCommitID, newCommitID string, commits *repository.PushCommits) {

[zeripath]

To me it seems that simply copying the code for NotifyPushCommits would suffice to fix this issue.

[ghost]

It seems that this bug wasn't fixed in the 1.11.5 release. Was the backport included in this release?

[zeripath]

gitea/modules/notification/indexer/indexer.go

Line 127 in 83f8414

func (r *indexerNotifier) NotifySyncPushCommits(pusher *models.User, repo *models.Repository, refName, oldCommitID, newCommitID string, commits *models.PushCommits) {