Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Teams on-multiple-commit message hard to read #12255

Closed
2 of 7 tasks
vijfhoek opened this issue Jul 15, 2020 · 3 comments · Fixed by #13081
Closed
2 of 7 tasks

Microsoft Teams on-multiple-commit message hard to read #12255

vijfhoek opened this issue Jul 15, 2020 · 3 comments · Fixed by #13081
Labels
good first issue Likely to be an easy fix hacktoberfest issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@vijfhoek
Copy link
Contributor

  • Gitea version (or commit ref): 1.12.2
  • Git version: (don't think that's relevant)
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

Currently, the message that's sent when multiple commits puts all commits on a single line, while showing everything in a multi-line commit. This makes them rather hard to read.

May I suggest changing the messages to add a newlines after every commit, and only showing the first line of each commit to reduce noise. If users want to read the rest of the commit, they can just click "View in Gitea".

Screenshots

Current situation:

image

image

Suggestion:

image

image

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jul 15, 2020
@stale
Copy link

stale bot commented Sep 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Sep 13, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 13, 2020
@stale stale bot removed the issue/stale label Sep 13, 2020
@zeripath zeripath added the good first issue Likely to be an easy fix label Sep 13, 2020
@zeripath
Copy link
Contributor

This would likely be a very easy pr

@vijfhoek
Copy link
Contributor Author

vijfhoek commented Sep 14, 2020

I have in fact already fixed this, but haven't been able to test it yet (it's kind of bothersome to set everything up for testing with Teams and all).

I can try to set up a test env sometime this week

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Likely to be an easy fix hacktoberfest issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants