Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line break for MS teams webhook #13081

Merged

Conversation

ivanvc
Copy link
Contributor

@ivanvc ivanvc commented Oct 9, 2020

Adds an extra line break to multi commit messages from MS teams webhook.

This is how it looks now:

image

Fixes #12255.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@techknowlogick techknowlogick added this to the 1.13.0 milestone Oct 9, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 9, 2020
@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #13081 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13081      +/-   ##
==========================================
- Coverage   42.60%   42.60%   -0.01%     
==========================================
  Files         673      673              
  Lines       73858    73858              
==========================================
- Hits        31466    31465       -1     
+ Misses      37292    37287       -5     
- Partials     5100     5106       +6     
Impacted Files Coverage Δ
modules/webhook/msteams.go 0.00% <0.00%> (ø)
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
models/notification.go 65.76% <0.00%> (-0.91%) ⬇️
models/error.go 34.85% <0.00%> (-0.34%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (ø)
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
services/mailer/mail.go 55.91% <0.00%> (+1.07%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508aca1...f954821. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2020
@techknowlogick techknowlogick merged commit 06f1cdd into go-gitea:master Oct 9, 2020
@ivanvc ivanvc deleted the fix-msteams-multiline-webhook branch October 9, 2020 14:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft Teams on-multiple-commit message hard to read
5 participants