Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when uploading images #12339

Closed
1 of 6 tasks
donnyv opened this issue Jul 27, 2020 · 4 comments · Fixed by #12447
Closed
1 of 6 tasks

Error when uploading images #12339

donnyv opened this issue Jul 27, 2020 · 4 comments · Fixed by #12447

Comments

@donnyv
Copy link

donnyv commented Jul 27, 2020

  • Gitea version (or commit ref): 1.12.2 built with GNU Make 4.1, go1.14.4 : bindata, sqlite, sqlite_unlock_notify
  • Git version: 2.27.0
  • Operating system: Windows Server 2019
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • [x ] No
    • Not relevant
  • Log gist:

Description

Every time I upload an image I get this error. Weird thing is it uploads the file fine and I can use it. I'm guessing its having issues deleting this temp file. Not sure why since I have not had any issues creating repositories on this server or pushing updates.

image

...

Screenshots
@shenlijun
Copy link

linux server would be fine

I tested both windows and linux，clean windows and Linux with Anti-virus software

@zeripath
Copy link
Contributor

zeripath commented Aug 6, 2020

do you have antivirus running?

zeripath added a commit to zeripath/gitea that referenced this issue Aug 6, 2020
@zeripath
Re-attempt to delete temporary upload if the process is locked
55e46b1 
Fix go-gitea#12339

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Aug 6, 2020
Merged
@donnyv
Copy link
Author

donnyv commented Aug 7, 2020

do you have antivirus running?

No

@zeripath
Copy link
Contributor

zeripath commented Aug 9, 2020

Something must be holding on to the file but I'm not certain what could be doing that. Could you try a build of pr #12447 ?

zeripath added a commit that referenced this issue Aug 11, 2020
@zeripath @silverwind
Re-attempt to delete temporary upload if the file is locked by anothe…
74bd969 
…r process (#12447)

Replace all calls to os.Remove/os.RemoveAll by retrying util.Remove/util.RemoveAll and remove circular dependencies from util.

Fix #12339

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-attempt to delete temporary upload if the file is locked by another process zeripath/gitea
3 participants
@zeripath @donnyv @shenlijun