Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links for commit hashes ending in comma are not rendered #14223

Closed
1 of 2 tasks
nuno-silva opened this issue Jan 3, 2021 · 0 comments · Fixed by #14224
Closed
1 of 2 tasks

Links for commit hashes ending in comma are not rendered #14223

nuno-silva opened this issue Jan 3, 2021 · 0 comments · Fixed by #14224
Labels
Milestone

Comments

@nuno-silva
Copy link
Contributor

Description

When leaving an issue comment containing valid commit hashes, those are not recognised if they are followed by a comma (,).
A workaround is to leave a space between the hash and the comma, but you need to remember to do it when writing the comment or go back and edit it after noticing the commit link was not rendered.
Dots are accepted though. See the screenshot for reference.

Unless there was a specific reason for not accepting commas, this is an easy fix.
I will prepare a pull request in a bit.

Screenshots

raw text rendered text

@lunny lunny added the type/bug label Jan 3, 2021
nuno-silva added a commit to nuno-silva/gitea that referenced this issue Jan 3, 2021
@lunny lunny added this to the 1.13.2 milestone Jan 3, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants