-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unprotected file patterns #16381
Comments
It could probably be added as selection on what behavior is expected for patterns matching |
What if we want to configure both protected file patterns AND unprotected file patterns though? |
They would be conflicting imho, how that would work? |
I think they are complementary. For example:
And protected_file_patterns takes precedence: when a changed path matches both protected_file_patterns and unprotected_file_patterns, it will be treated as protected. |
But if I understand correctly that if I have write to the repo and there is unprotected_file_patterns set like in your example I would not be able to modify |
With unprotected_file_patterns, people with write access to the repo can modify those files even if they are not allowed to push directly to the branch. It is to allow to bypass the PR workflow. |
Fixes #16381 Note that changes to unprotected files via the web editor still cannot be pushed directly to the protected branch. I could easily add such support for edits and deletes if needed. But for adding, uploading or renaming unprotected files, it is not trivial. * Extract & Move GetAffectedFiles to modules/git
Currently, in the branch protection settings, "Protected file patterns" can be configured:
I propose to add support for configuring the counterpart of this: "Unprotected file patterns".
Users with write access to the repo should be able to push commits that only touch unprotected files directly to the otherwise protected branch.
The text was updated successfully, but these errors were encountered: