-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming repositories does result in 500 error. #16427
Comments
are you running the go-git or non-go-git variant? |
I am having the exact same issue, running this release on windows -> https://dl.gitea.io/gitea/1.14.4 |
Maybe you could close your anti-virus software and try again. |
Okay, I have found something. It seems to only happen if you use the option "initialize repository". It might be git doesn't free the .git file in the background. Edit: If I create an empty repository I can rename it. If I initialize OR push to it, I cannot rename it any longer, resulting in error 500. |
@julian-go are you running the go-git variant or not? |
Can you try on 1.15 also. |
How can I find out? https://dl.gitea.io/gitea/1.14.4/gitea-1.14.4-windows-4.0-amd64.exe |
OK you're running the non-gogit variant. |
As lunny asks above are you @julian-go running antivirus? |
Yes, but its a corporate environment and I cannot turn it off unfortunately. |
I asked my admin if the virus scanner can be turned of for 10 minutes for testing purpose. I will let You know asap when I got a chance to test the behavior. I use the same download file as @julian-go . |
Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix go-gitea#16427 Signed-off-by: Andrew Thornton <art27@cantab.net>
Please try #16435 |
The error occurs also with a disabled McAfee virus scanner. I will test again when a release with the commit #zeripath@05d4a69 is available. |
It won't get released or merged without someone doing some testing. |
I can make a build with #16435 backported to 1.14 |
* Retry rename on lock induced failures Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix #16427 Signed-off-by: Andrew Thornton <art27@cantab.net> * resolve CI fail Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Backport go-gitea#16435 Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix go-gitea#16427 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Backport #16435 Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix #16427 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
…and to end Fix go-gitea#16427 (again!) Signed-off-by: Andrew Thornton <art27@cantab.net>
…and to end (go-gitea#16479) Fix go-gitea#16427 (again!) Signed-off-by: Andrew Thornton <art27@cantab.net>
…and to end Fix go-gitea#16427 (again!) Signed-off-by: Andrew Thornton <art27@cantab.net>
* Retry rename on lock induced failures Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix go-gitea#16427 Signed-off-by: Andrew Thornton <art27@cantab.net> * resolve CI fail Co-authored-by: techknowlogick <techknowlogick@gitea.io>
…and to end (go-gitea#16479) Fix go-gitea#16427 (again!) * handle sharing violation error code Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
[x]
):Description
I want to rename a repository but it isn't possible. I just get a "500" error. The log file contains the following message but not more:
In English the message is something like: The process can't access the file. It is open by another process.
Screenshots
Not relevant.
The text was updated successfully, but these errors were encountered: