Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix URIs aren't rendered as links #16721

Closed
1 task done
Mikaela opened this issue Aug 18, 2021 · 2 comments · Fixed by #24805
Closed
1 task done

Matrix URIs aren't rendered as links #16721

Mikaela opened this issue Aug 18, 2021 · 2 comments · Fixed by #24805
Labels
outdated/theme/markdown type/enhancement An improvement of existing functionality

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Aug 18, 2021

Description

Linking to a Matrix URI such as: [Mikaela.info](matrix:roomid/psumPMeAfzgAeQpXMG:feneas.org?action=join&via=feneas.org&via=sorunome.de&via=the-apothecary.club&via=pirateriot.net&via=matrix.org) renders as text instead of a clickable link.

Matrix URI scheme is proposed in https://github.com/matrix-org/matrix-doc/blob/master/proposals/2312-matrix-uri.md and is being proposed in matrix-org/matrix-spec-proposals#3168.

Update: Matrix URI scheme is specified in Matrix 1.2 and recognised by IANA.

Screenshots

@noerw noerw added outdated/theme/markdown type/bug type/enhancement An improvement of existing functionality and removed type/bug labels Aug 23, 2021
@ShadowJonathan
Copy link

FWIW, matrix: is a properly recognised URI at the moment; https://www.iana.org/assignments/uri-schemes/prov/matrix

The URI is already proposed and has passed a "final comment period" in matrix-org/matrix-spec-proposals#2312, and matrix-org/matrix-spec-proposals#3168 is only to formalise the wording into the specification.

@Mikaela
Copy link
Contributor Author

Mikaela commented May 4, 2022

I updated the original comment a bit on that Matrix URI scheme became part of Matrix Specification in version 1.2 and included the IANA bit.

silverwind pushed a commit that referenced this issue May 19, 2023
- Closes #21146
- Closes #16721

## ⚠️ BREAKING ⚠️
This changes the default behavior to now create links for any URL scheme
when the user uses the markdown form for links (`[label](URL)`), this
doesn't affect the rendering of inline links. To opt-out set the
`markdown.CUSTOM_URL_SCHEMES` setting to a list of allowed schemes, all
other schemes (except `http` and `https`) won't be allowed.

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/35fa18ce-7dda-4995-b5b3-3f360f38296d)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/0922216b-0b35-4b77-9919-21a5c21dd5d0)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated/theme/markdown type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants