Closing an issue which has open dependencies does not show any error #18223
Labels
issue/regression
Indicates a previously functioning feature or behavior that has broken or regressed after a change
topic/ui
Change the appearance of the Gitea UI
type/bug
Milestone
Comments
zeripath
added
the
issue/regression
|
This is a regression due to #17643 - we should be handling the dependency error in the callers. |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jan 18, 2022
Unfortunately go-gitea#17643 prevented all propagation of ErrDependenciesLeft meaning that dependency errors that prevent closing of issues get swallowed. This PR restores propagation of the error but instead swallows the error in the places where it needs to be swallowed. Fix go-gitea#18223 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
that referenced
this issue
Jan 18, 2022
Unfortunately #17643 prevented all propagation of ErrDependenciesLeft meaning that dependency errors that prevent closing of issues get swallowed. This PR restores propagation of the error but instead swallows the error in the places where it needs to be swallowed. Fix #18223 Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
Unfortunately go-gitea#17643 prevented all propagation of ErrDependenciesLeft meaning that dependency errors that prevent closing of issues get swallowed. This PR restores propagation of the error but instead swallows the error in the places where it needs to be swallowed. Fix go-gitea#18223 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Gitea Version
1.16.0+dev-819-g3a0dee01e
Git Version
No response
Operating System
No response
How are you running Gitea?
try.gitea.io + 1.15.9 on https://Codeberg.org
Database
MySQL
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Description
https://try.gitea.io/fnetx/dependencytesting/issues/2
If an issue depends on another one which is not closed, trying to close the issue with dependencies fails but does not show any helpful error in the UI. This might be confusing to users, they might either miss the issue wasn't closed, or wonder why it cannot be closed when they don't notice the dependencies.
Screenshots
No response
The text was updated successfully, but these errors were encountered: