Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Permission Table Bug #18483

Closed
AaronS8 opened this issue Jan 31, 2022 · 6 comments · Fixed by #18496
Closed

Team Permission Table Bug #18483

AaronS8 opened this issue Jan 31, 2022 · 6 comments · Fixed by #18496
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented

Comments

@AaronS8
Copy link

AaronS8 commented Jan 31, 2022

Gitea Version

1.16.0 && 1.17.0+dev-32-gab7f70167

Git Version

2.33

Operating System

Windows 10

How are you running Gitea?

I'am running Gitea as a service

Database

PostgreSQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

Team Permmission Table bugs

Bugs

  1. if I give a team admin rights I can't change it back to general access
  2. if I give a team general access and give all read permission but one permission to write access, the team have readonly access
  3. and team members won't be able to assigned a project even if they have write access on code, issue which means they aren't recoginzed as collabrators

Tested Databases

  • MSSQLServer
  • MySql
  • Sqlite

Links

https://gitea.com/org/BugTester/teams/collabrotors/edit

Screenshots

bug1
bug2

@AaronS8 AaronS8 changed the title Team Permission Team Permission Table Bug Jan 31, 2022
Gusted pushed a commit to Gusted/gitea that referenced this issue Jan 31, 2022
- Currently the `.Team.AccessMode` is being used when editing a team, if
you want to admin -> General Access, the value of General Access is
"admin" which is incorrect.
- Resolves go-gitea#18483 (First bug mentioned)
@Gusted Gusted added type/bug issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Jan 31, 2022
@Gusted
Copy link
Contributor

Gusted commented Jan 31, 2022

I was able to reproduce the first and third bug. The first bug was a regression and is fixed by #18496, the third bug is another issue which was is currently the behavior(so it should be a new issue as enhancement). The second bug is too vague to understand/reproduce.

@Gusted Gusted removed the type/bug label Jan 31, 2022
@lunny
Copy link
Member

lunny commented Feb 1, 2022

The first bug is when check admin access and then check general access, the access table will not be shown again.

lunny added a commit that referenced this issue Feb 1, 2022
- Currently the `.Team.AccessMode` is being used when editing a team, if
you want to admin -> General Access, the value of General Access is
"admin" which is incorrect.
- Resolves #18483 (First bug mentioned)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@AaronS8
Copy link
Author

AaronS8 commented Feb 1, 2022

@lunny setting the general access and admin is fixed but the team mebers can't be assigned an issue even if they have write permmision in the code and read or write on the issue and one read permssion (any unit) .
but if there is no read only permission only write and no access the problems doesn't exist, They can be assigned

@lunny lunny reopened this Feb 1, 2022
@zeripath
Copy link
Contributor

zeripath commented Feb 1, 2022

  1. if I give a team admin rights I can't change it back to general access I think this is fixed by Use "read" value for General Access #18496
  2. if I give a team general access and give all read permission but one permission to write access, the team have readonly access
  3. team members won't be able to assigned a project even if they have write access on code, issue which means they aren't recoginzed as collabrators

@zeripath
Copy link
Contributor

zeripath commented Feb 1, 2022

As @Gusted said above we're a little confused by number 2 here. Would it be possible for you to create an org with teams on try.gitea.io that replicates the issue. Use temporary users that you can share the passwords of here.

@AaronS8
Copy link
Author

AaronS8 commented Feb 2, 2022

Sorry I couldn't create temporary users in try.gitea.io since I have slow internet, but I think number 2 is fixed after I upgraded my gitea to v1.17.0+dev-75-g7f2530e00.

@AaronS8 AaronS8 closed this as completed Feb 2, 2022
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
- Currently the `.Team.AccessMode` is being used when editing a team, if
you want to admin -> General Access, the value of General Access is
"admin" which is incorrect.
- Resolves go-gitea#18483 (First bug mentioned)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants