Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP (simple auth) authentication may not cover email and username at the same time #18812

Closed
philipphutterer opened this issue Feb 18, 2022 · 1 comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@philipphutterer
Copy link

philipphutterer commented Feb 18, 2022

Gitea Version

1.16.0

Description

I want to be able to login with either email or username through LDAP (simple auth), but both should be possible. The User-DN for email login is not equal to the User-DN for a username login. I am aware that there is the option to add two LDAP sources that only differ in the User-DN. That unfortunately only works in such a way, that once a user logged in with either email or username, its account is bound to that method. The system does not check other sources than the one bound (see signin.go).

In my opinion there should either be an option to add multiple User-DN entries in a single source or the system should check multiple sources even if a user is already found in the database (but only for authentication).

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 19, 2022
@philipphutterer
Copy link
Author

basically fixed with #18800

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants