Fix login with email for ldap users #18800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
backport/v1.16
skip-changelog
singuliere
approved these changes
Feb 18, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
approved these changes
Feb 19, 2022
GiteaBot
added
lgtm/done
|
Are we sure about this? I guess this is right, the user has created a new username-alias pair for gitea so when they're logging in they actually mean |
Codecov Report
@@ Coverage Diff @@
## main #18800 +/- ##
=======================================
Coverage ? 46.49%
=======================================
Files ? 853
Lines ? 122473
Branches ? 0
=======================================
Hits ? 56947
Misses ? 58638
Partials ? 6888
Continue to review full report at Codecov.
|
|
make lgtm work |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Feb 20, 2022
`authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 21, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin Show fullname on issue edits and gpg/ssh signing info (go-gitea#18827) Update go-org to 1.6.0 (go-gitea#18824) Fix login with email for ldap users (go-gitea#18800) [skip ci] Updated licenses and gitignores Immediately Hammer if second kill is sent (go-gitea#18823)
techknowlogick
added a commit
that referenced
this pull request
Feb 22, 2022
`authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
`authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authenticator.Authenticatehas assume the login name is not an email, butusernamemaybe an email. So when we find the user via email address, we should useuser.LoginNameinstead ofusernamewhich is an email address.