Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show fullname on issue edits and gpg/ssh signing info #18827

Merged
merged 5 commits into from
Feb 20, 2022
Merged

Show fullname on issue edits and gpg/ssh signing info #18827

merged 5 commits into from
Feb 20, 2022

Conversation

42wim
Copy link
Member

@42wim 42wim commented Feb 19, 2022

Show missing full names when configured to do so

@42wim 42wim mentioned this pull request Feb 19, 2022
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 20, 2022
@singuliere singuliere added the topic/ui Change the appearance of the Gitea UI label Feb 20, 2022
@singuliere singuliere added this to the 1.17.0 milestone Feb 20, 2022
singuliere
singuliere approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@singuliere singuliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2022
@lunny
Copy link
Member

lunny commented Feb 20, 2022

Should we really need to backport this to v1.16?

@42wim
Copy link
Member Author

42wim commented Feb 20, 2022

@lunny why not? it's a simple bugfix?

@lunny
Copy link
Member

lunny commented Feb 20, 2022

@lunny why not? it's a simple bugfix?

Could you paste some screenshots?

@42wim
Copy link
Member Author

42wim commented Feb 20, 2022 •
edited
Loading

before
image

image

after
image

image

@zeripath zeripath merged commit a387636 into go-gitea:main Feb 20, 2022
@zeripath
Copy link
Contributor

Please send backport

@42wim
Copy link
Member Author

42wim commented Feb 20, 2022

@zeripath #18828

@42wim 42wim deleted the fullnamefix branch February 20, 2022 21:57
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
33db79e 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Show fullname on issue edits and gpg/ssh signing info (go-gitea#18827)
  Update go-org to 1.6.0 (go-gitea#18824)
  Fix login with email for ldap users (go-gitea#18800)
  [skip ci] Updated licenses and gitignores
  Immediately Hammer if second kill is sent (go-gitea#18823)
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 9, 2022
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@42wim @zeripath
Show fullname on issue edits and gpg/ssh signing info (go-gitea#18827)
c4020d9 
Show missing full names when configured to do so

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath left review comments

@lunny lunny lunny approved these changes

@singuliere singuliere singuliere approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@42wim @lunny @zeripath @singuliere @GiteaBot