Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately Hammer if second kill is sent #18823

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

zeripath
Copy link
Contributor

Currently Gitea will wait for HammerTime or nice shutdown if kill -1 or kill -2
is sent. We should just immediately hammer if there is a second kill.

Signed-off-by: Andrew Thornton art27@cantab.net

Currently Gitea will wait for HammerTime or nice shutdown if kill -1 or kill -2
is sent. We should just immediately hammer if there is a second kill.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/enhancement An improvement of existing functionality backport/v1.16 labels Feb 19, 2022
@zeripath zeripath added this to the 1.17.0 milestone Feb 19, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@159c3f4). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18823   +/-   ##
=======================================
  Coverage        ?   46.58%           
=======================================
  Files           ?      853           
  Lines           ?   122472           
  Branches        ?        0           
=======================================
  Hits            ?    57055           
  Misses          ?    58528           
  Partials        ?     6889           
Impacted Files Coverage Δ
modules/graceful/manager.go 22.16% <0.00%> (ø)
modules/graceful/manager_unix.go 38.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159c3f4...fc2021b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2022
@zeripath
Copy link
Contributor Author

make lgtm work

@zeripath zeripath merged commit 83c9035 into go-gitea:main Feb 19, 2022
@zeripath zeripath deleted the a-second-kill-should-hammer branch February 19, 2022 16:36
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 19, 2022
Backport go-gitea#18823

Currently Gitea will wait for HammerTime or nice shutdown if kill -1 or kill -2
is sent. We should just immediately hammer if there is a second kill.

Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny pushed a commit that referenced this pull request Feb 19, 2022
Backport #18823

Currently Gitea will wait for HammerTime or nice shutdown if kill -1 or kill -2
is sent. We should just immediately hammer if there is a second kill.

Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 21, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Show fullname on issue edits and gpg/ssh signing info (go-gitea#18827)
  Update go-org to 1.6.0 (go-gitea#18824)
  Fix login with email for ldap users (go-gitea#18800)
  [skip ci] Updated licenses and gitignores
  Immediately Hammer if second kill is sent (go-gitea#18823)
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 9, 2022
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Currently Gitea will wait for HammerTime or nice shutdown if kill -1 or kill -2
is sent. We should just immediately hammer if there is a second kill.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants