Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.17.1] Reaction icon problem #20860

Closed
tyroneyeh opened this issue Aug 19, 2022 · 1 comment · Fixed by #21185
Closed

[1.17.1] Reaction icon problem #20860

tyroneyeh opened this issue Aug 19, 2022 · 1 comment · Fixed by #21185
Labels
type/bug
Milestone
1.17.3

Comments

@tyroneyeh
Copy link
Contributor

Description

  1. Click +1 reaction in comment
  2. Click +1 on the first content to respond invalid
  3. Deselect +1 reaction in comments
  4. On the first content click +1 response is working
  5. Hit +1 reactions in comments
  6. In the first content deselect +1 reaction, comment reactions are also deselected
gitea_reaction-2022-08-19_16.08.55.mp4

Gitea Version

1.17.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Gentoo

How are you running Gitea?

systemd

Database

PostgreSQL
@lunny lunny added this to the 1.17.2 milestone Aug 19, 2022
@lunny lunny modified the milestones: 1.17.2, 1.17.3 Sep 5, 2022
@earl-warren
Copy link
Contributor

earl-warren commented Sep 15, 2022 •
edited
Loading

I confirm experiencing the same bug as described, in 1.17.2.

@wolfogre wolfogre mentioned this issue Sep 16, 2022
Merged
lunny pushed a commit that referenced this issue Sep 17, 2022
@wolfogre @lafriks
Fix reaction of issues (#21185)
34f736c 
Fix #20860.

`CommentID` in `FindReactionsOptions` should be -1 to search reactions
with zero comment id.


https://github.com/go-gitea/gitea/blob/8351172b6e5221290dc5b2c81e159e2eec0b43c8/models/issues/reaction.go#L108-L121

Co-authored-by: Lauris BH <lauris@nix.lv>
@wolfogre wolfogre mentioned this issue Sep 17, 2022
Merged
lunny pushed a commit that referenced this issue Sep 18, 2022
@wolfogre @lafriks
Fix reaction of issues (#21185) (#21196)
c8d6879 
Backport #21185.

Fix #20860.

`CommentID` in `FindReactionsOptions` should be -1 to search reactions
with zero comment id.



https://github.com/go-gitea/gitea/blob/8351172b6e5221290dc5b2c81e159e2eec0b43c8/models/issues/reaction.go#L108-L121

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.17.3
Development

Successfully merging a pull request may close this issue.

Fix reaction of issues
3 participants
@lunny @tyroneyeh @earl-warren