-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-installation support #209
Comments
Why would it not be the same as |
The first three could, but the last three cannot |
Hmm. "add auth source" could, see #183. The other two indeed should not. But that are post-installation steps, imo. |
IMO just create a
|
lack of auth sources. |
Run user, admin user, database and auth sources are not install vars but global config vars that should be kept in a config file that is loaded on every run, not black-box inserted on install. There is no need for pre-installation stuff, I setup a whole lot self-hosted applications and none have them. What they have is a config file that contains all you need. Post-installation actions might make sense, though. F.e. adding users and organisations. However shouldn't the API allow for this when you provide an admin user in app.ini? |
@stevenroose, I don't think so. Installation and Configuration are not the same things. Installation should have something you can not easily change. i.e. database, run user, data root dir. If you changed these, you have to restart your system. Adding users/organizations, adding auth source, config sendmail and etc. are configurations and could be changed when system is running. |
I would prefer a single file as well. And if authentication sources are defined via config I would even disable editing via ui |
@lunny Almost all of them you could in theory change at runtime except maybe run user. But almost all of them you probably don't want to do that at runtime. Things like database, datadirs, auth source, sendmail are core configurations and will almost never change once your system is deployed. They shouldn't too. |
@stevenroose Gitea currently makes no effort at separating global/install var so currently it's sort-of a moot argument. Being able to bootstrap an instance is really helpful :) |
@bkcsoft Yeah but there currently is a global config file and no install config file, so instead of making the latter, I think it makes more sense to just put it into the already existing config file :) Makes installation much more intuitive for new users too, just fill in the app.ini file and run and you're done. |
with #354 that will be easier since the default |
To add my two cents worth. I think we ought to continue to be careful to keep the use of However the items "add users", "add or organizations" "migrate git repos" are once off admin activities and should not happen every time the server starts. Therefore they belong nowhere near a settings file. I believe the best idea would be a command line API. Rather than a
This lets user create shell scripts or batch scripts which are as complex or simple as their needs. It also provides some simple solutions to lost admin passwords etc. |
reset someuser's password.
|
@lunny with an optional password for those of us that don't have an email server setup 😉
|
@bkcsoft This only for who forget admin password. If you have admin password, you can change user's password in |
@lunny unless you want a cron-job that changes their password every 3 months ;) |
Instead of storing "dynamic configuration variables" in the database, one could keep them in the same config file and support reload instead of restart of gitea. (think apache/nginx reload vs restart) |
We would like to to use gitea for out of the box git support in the fabric8.io project - which uses KeyCloak as an identity provider (Oauth). Being able to configure the OAuth provider in a configuration file seems to be the only way forward for us. |
What about a config directory that would always start with a default app.ini.whatever. app.ini.whatever would be the starting point with the other files being merged and overriding any settings app.ini.whatever? Similar to /etc/whatever.d style directories |
Was any support for this ever added? I have the same use case as @rajdavies . I already have Keycloak up and running and in my environment, there is no real way to open a web UI and make changes. Being able to put everything in a config file for Ansible or some other CM tool to bootstrap the installation and configuration is key. |
I think now every thing listed could be done via app.ini or gitea command lines. |
Where can I find the related docs? |
This feature is very useful for rapidly creating an OEM Gitea instance. All the pre-installation will only need give a specific ini file. This file is not the same as the config.ini.
The text was updated successfully, but these errors were encountered: