Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display changes in PR since last review / since specified commit #20989

Closed
Artalus opened this issue Aug 29, 2022 · 7 comments · Fixed by #25528
Closed

Display changes in PR since last review / since specified commit #20989

Artalus opened this issue Aug 29, 2022 · 7 comments · Fixed by #25528
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@Artalus
Copy link

Artalus commented Aug 29, 2022

Feature Description

GitHub and GitLab have this great feature which allows you to see exactly what have changed in the PR since the last time you've looked at it. In Gitea it seems that the only option currently is to view commits one be one.

A tiny step in that directions was made in PR #19007 though it only labels the files as "changed since" instead of providing the diff. Also there are issues #12800 and #19862 , which are more "generalized" versions of this feature request.

Screenshots

  • Github:
    image
  • Gitlab:
    image
@Artalus Artalus added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Aug 29, 2022
@thammaknot
Copy link

This feature would be awesome. I miss it moving from gitlab/github as well.
Thank you for proposing.

@cy18
Copy link

cy18 commented Dec 19, 2022

I'm missing this feature too. After migrating from gitlab to gitea for about one year, this is the only defect of gitea.

@lunny
Copy link
Member

lunny commented Dec 19, 2022

Maybe #13313 could fix this one?

@Artalus
Copy link
Author

Artalus commented Dec 19, 2022

From the issues mentioned there, it seems that people do have a common need - to see what was updated in PR (whether force-push, amends and rebases are involved or not).

Given that Gitea already has an URL /compare/commitA...commitB, one could start from at least adding a user-friendly interface for that in PR page. However it is actually just a comparison of two arbitrary commits, and does not allow reviewing for example.

@cy18
Copy link

cy18 commented Dec 20, 2022

/compare/commitA...commitB

The /compare/commitA...commitB does not eliminate identical changes of the two commits.

@sebastian-sauer sebastian-sauer mentioned this issue Jul 6, 2023
Merged
@sebastian-sauer
Copy link
Contributor

#25528 implements a first version of this commit selector

changes since last review could be a next PR

@sebastian-sauer
Copy link
Contributor

Update: the display changes since last review is now implemented, too ;-)

delvh added a commit that referenced this issue Jul 28, 2023
@sebastian-sauer @silverwind
@KN4CK3R @wxiaoguang @delvh
Add commits dropdown in PR files view and allow commit by commit revi…
5553206 
…ew (#25528)

This PR adds a new dropdown to select a commit or a commit range
(shift-click like github) of a Pull Request.
After selection of a commit only the changes of this commit will be shown.
When selecting a range of commits the diff of this range is shown.

This allows to review a PR commit by commit or by viewing only commit ranges.
The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.

## Screenshots

### The commit dropdown

![image](https://github.com/go-gitea/gitea/assets/51889757/0db3ae62-1272-436c-be64-4730c5d611e3)

### Selecting a commit range

![image](https://github.com/go-gitea/gitea/assets/51889757/ad81eedb-8437-42b0-8073-2d940c25fe8f)

### Show changes of a single commit only

![image](https://github.com/go-gitea/gitea/assets/51889757/6b1a113b-73ef-4ecc-adf6-bc2340bb8f97)

### Show changes of a commit range

![image](https://github.com/go-gitea/gitea/assets/51889757/6401b358-cd66-4c09-8baa-6cf6177f23a7)


Fixes #20989
Fixes #19263

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add commits dropdown in PR files view and allow commit by commit review sebastian-sauer/gitea
5 participants
@lunny @sebastian-sauer @thammaknot @Artalus @cy18