-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted users lead to 500 responses on various time-related API endpoints #22006
Comments
Have you tried to upgrade to 1.17.3 ? |
Yes, did it just now. Issue is still present. |
It would be very helpful to see the logs for these. |
I am sorry, we did not retain logs. But repro should be easy:
|
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Dec 3, 2022
When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.) Fix go-gitea#22006 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this issue
Dec 4, 2022
When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.) Fix #22006 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Dec 4, 2022
Backport go-gitea#22021 When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.) Fix go-gitea#22006 Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
pushed a commit
that referenced
this issue
Dec 5, 2022
Backport #22021 When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.) Fix #22006 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
When a user deletes their account, they become a
Ghost
account.Such a user may already have logged time on issues.
In such a case, the following web API endpoints return 500.
/repos/{owner}/{repo}/issues/{index}/times
/repos/{owner}/{repo}/times
Other endpoints may also be affected, but our scripts did only ran into trouble here.
In particular not affected is
GET /repos/{owner}/{repo}/times/{user}
as long as user is not the id of a deleted user.Gitea Version
1.17.2
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
We are running Gitea with docker from
image: gitea/gitea:1.17.2
. Gitea DB ismariadb:10.9.2
. The web API is behind a traefik reverse proxy.Database
MySQL
The text was updated successfully, but these errors were encountered: