Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most recent commit with long first line causes repo view to overflow #22360

Closed
madeline-holland opened this issue Jan 7, 2023 · 2 comments · Fixed by #22551
Closed

Most recent commit with long first line causes repo view to overflow #22360

madeline-holland opened this issue Jan 7, 2023 · 2 comments · Fixed by #22551
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@madeline-holland
Copy link

Description

Hello.

The changes in #21124, specifically here cause the repo file browser to overflow off the page when the most recent commit message has a long first line, which happens a lot when using the Gitea UI to merge two branches with median-length first lines, by default.

By having display: inline, the .commit-list .message-wrapper in the repository file browser doesn't respect the max-width to prevent overflow.

Changing display: inline to display: inline-block fixes the issue on the repository page, but breaks the changes in the above PR, otherwise I would have submitted a PR for it.

I cannot reproduce on the Gitea demo site because it won't allow me to create an account (500 error).

Screenshots

(Sorry for the obfuscation, I couldn't create an account on the demo site, otherwise I would have used that.)
screenshot-1
screenshot-2

Gitea Version

1.18.0

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Linux

Browser Version

Firefox 108.0, Google Chrome 108.0.5359.124
@madeline-holland madeline-holland added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 7, 2023
@madeline-holland
Copy link
Author

I was able to fix it on my end without effecting the other page with a header template file containing:

<style>
#repo-files-table .commit-list .message-wrapper {
    display: inline-block;
}
</style>

@lunny lunny mentioned this issue Jan 18, 2023
Closed
@silverwind
Copy link
Member

Fix suggestion in #22413 (comment).

@lunny lunny mentioned this issue Jan 19, 2023
Closed
@silverwind silverwind mentioned this issue Jan 20, 2023
Closed
zeripath added a commit to zeripath/gitea that referenced this issue Jan 20, 2023
@zeripath
Truncate commit summary on repo files table.
abdf0a3 
There was an unintended regression in go-gitea#21124 which assumed that
`.commits-list .message-wrapper` would only match the commit summaries
on `/{owner}/{name}/commits/*`. This assumption is incorrect as the
directory/file view also uses a `.commits-list` wrapper.

Rather than completely restructure this page this PR simply adjusts the
styling to again use `display: inline-block;` for `#repo-files-table .commit-list .message-wrapper`

Fix go-gitea#22360

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jan 20, 2023
Merged
yardenshoham added a commit to yardenshoham/gitea that referenced this issue Jan 20, 2023
@yardenshoham
Truncate commit summary on repo files table. (go-gitea#22551)
59d0779 
Backport go-gitea#22551
There was an unintended regression in go-gitea#21124 which assumed that .commits-list .message-wrapper would only match the commit summaries on /{owner}/{name}/commits/*. This assumption is incorrect as the directory/file view also uses a .commits-list wrapper.

Rather than completely restructure this page this PR simply adjusts the styling to again use display: inline-block; for #repo-files-table .commit-list .message-wrapper

Fix go-gitea#22360
@yardenshoham yardenshoham mentioned this issue Jan 20, 2023
Merged
lunny pushed a commit that referenced this issue Jan 20, 2023
@zeripath
Truncate commit summary on repo files table. (#22551)
b8eb282 
There was an unintended regression in #21124 which assumed that
`.commits-list .message-wrapper` would only match the commit summaries
on `/{owner}/{name}/commits/*`. This assumption is incorrect as the
directory/file view also uses a `.commits-list` wrapper.

Rather than completely restructure this page this PR simply adjusts the
styling to again use `display: inline-block;` for `#repo-files-table
.commit-list .message-wrapper`

Fix #22360

Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny pushed a commit that referenced this issue Jan 20, 2023
@yardenshoham
Truncate commit summary on repo files table. (#22551) (#22552)
c320cae 
Backport #22551
There was an unintended regression in #21124 which assumed that
.commits-list .message-wrapper would only match the commit summaries on
/{owner}/{name}/commits/*. This assumption is incorrect as the
directory/file view also uses a .commits-list wrapper.

Rather than completely restructure this page this PR simply adjusts the
styling to again use display: inline-block; for #repo-files-table
.commit-list .message-wrapper

Fix #22360
@Maks1mS Maks1mS mentioned this issue Feb 11, 2023
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Truncate commit summary on repo files table. zeripath/gitea
2 participants
@silverwind @madeline-holland