Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organization team access control dont work #22600

Closed
yp05327 opened this issue Jan 25, 2023 · 4 comments · Fixed by #22661
Closed

Organization team access control dont work #22600

yp05327 opened this issue Jan 25, 2023 · 4 comments · Fixed by #22661
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@yp05327
Copy link
Contributor

yp05327 commented Jan 25, 2023

Description

  1. You need to have two account. One is admin user1, the other one is normal user2.
  2. Use the admin account to create an organization, and create a new repo.
  3. Add a new team, set Repository access to All repositories and all unit to No Access except Issue or any other, this is not important.
  4. Add user2 to this team
  5. Use user2 to access the repo, and all unit can be accessed.

If you check the settings of the repo, you will see this team only has Read permission of Issues.
But user2 can access all units.

create new team

team settings

add user2 to this team

team user of the org

user2 can access all unit

user2 can see the code

the settings of the repo shows the new added team only has Read permission of Issues.

repo settings

Tips:
try.gitea.io can't create organization so i tested this at gitea.com. All screenshots are taken at gitea.com, not my local server.

Gitea Version

1.18.3, 1.19.0+dev-334-g0c048e554

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

run gitea-1.18.3-windows-4.0-amd64.exe on win10
&
gitea.com

Database

SQLite
@lunny
Copy link
Member

lunny commented Jan 29, 2023

Because the repository is a public one, you need to change it to private.

@lunny lunny added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels Jan 29, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Jan 29, 2023

Change to private is correct.
Thanks.

@yp05327 yp05327 closed this as completed Jan 29, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Jan 30, 2023 •
edited
Loading

@lunny
I think we can add some explanations to avoid making the same mistake again?

eg:

Allow Access to Repository Sections*
The following access control options have no effect on the public repositories in this organization.

@yp05327 yp05327 reopened this Jan 30, 2023
@lunny
Copy link
Member

lunny commented Jan 30, 2023

Could you help to send a PR for that? Thanks in advance.

@yp05327 yp05327 mentioned this issue Jan 30, 2023
Merged
lunny pushed a commit that referenced this issue Feb 1, 2023
@yp05327 @wolfogre
Explain that the no-access team unit does not affect public repositor…
72a83dc 
…ies (#22661)

Fixes #22600

Add explanations to team unit access control.

---------

Co-authored-by: Jason Song <i@wolfogre.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explain that the no-access team unit does not affect public repositories yp05327/gitea
2 participants
@lunny @yp05327