Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incurrect ui in creating projects page #22901

Closed
yp05327 opened this issue Feb 14, 2023 · 2 comments · Fixed by #22905
Closed

Incurrect ui in creating projects page #22901

yp05327 opened this issue Feb 14, 2023 · 2 comments · Fixed by #22905
Labels
type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Feb 14, 2023 •
edited
Loading

Description

Create Project is incurrect in some special size of the browser
image

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@wxiaoguang
Copy link
Contributor

Do you mean the incorrect height? If yes, I guess it's related to #22883 and fixed by #22885

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 14, 2023 •
edited
Loading

Oh sorry, the problem isn't fixed. I will take a look at it.

Update: Fix the full-height problem for all pages #22905

@wxiaoguang wxiaoguang mentioned this issue Feb 14, 2023
Merged
lunny added a commit that referenced this issue Feb 14, 2023
@wxiaoguang @lunny
Fix the full-height problem for all pages (#22905)
e314c9e 
Really fix #22883, close #22901

I made a mistake that the global styles in RepoActionView.vue could
still pollute global styles (I forgot that the code of this component is
still loaded on every page, instead of loaded on demand)

This PR makes a complete fix: only change the page's full-height
behavior if the component is used.

Screenshot after the fix:

<details>

![image](https://user-images.githubusercontent.com/2114189/218664776-0dbcd469-2c36-4e17-972f-e44fa3b81ba6.png)

</details>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the full-height problem for all pages wxiaoguang/gitea
2 participants
@wxiaoguang @yp05327