Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty notice on Matrix #23742

Closed
ptman opened this issue Mar 27, 2023 · 1 comment · Fixed by #27839
Closed

Empty notice on Matrix #23742

ptman opened this issue Mar 27, 2023 · 1 comment · Fixed by #27839
Labels
type/bug

Comments

@ptman
Copy link
Contributor

ptman commented Mar 27, 2023

Description

Pushing packages causes a notification to be sent via Matrix (as it should), but the notification is empty. Here's the output from devtools:

{
  "type": "m.room.message",
  "sender": "@gitea:domain.tld",
  "content": {
    "body": "",
    "msgtype": "m.notice",
    "format": "",
    "formatted_body": ""
  },
  "event_id": "$16799077162395uSyzy:domain.tld",
  "origin_server_ts": 1679907716675,
  "unsigned": {
    "age": 113167
  },
  "room_id": "!AlQEYiOnameiBnPOIj:domain.tld"
}

Other notifications (PR, Issues, ...) work fine.

Gitea Version

1.18.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

PostgreSQL
@ptman ptman added the type/bug label Mar 27, 2023
@ptman
Copy link
Contributor Author

ptman commented Oct 30, 2023

This still happens on 1.20.5

@lunny lunny mentioned this issue Oct 30, 2023
Merged
techknowlogick pushed a commit that referenced this issue Oct 31, 2023
@lunny @KN4CK3R
Fix package webhook (#27839)
16d15ce 
Fix #23742

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@GiteaBot GiteaBot mentioned this issue Oct 31, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Oct 31, 2023
@lunny @KN4CK3R @GiteaBot
Fix package webhook (go-gitea#27839)
fa807c6 
Fix go-gitea#23742

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@GiteaBot GiteaBot mentioned this issue Oct 31, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Oct 31, 2023
@lunny @KN4CK3R @GiteaBot
Fix package webhook (go-gitea#27839)
82936de 
Fix go-gitea#23742

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
silverwind pushed a commit that referenced this issue Oct 31, 2023
@GiteaBot @lunny @KN4CK3R
Fix package webhook (#27839) (#27854)
2147bfd 
Backport #27839 by @lunny

Fix #23742

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
silverwind pushed a commit that referenced this issue Oct 31, 2023
@GiteaBot @lunny @KN4CK3R
Fix package webhook (#27839) (#27855)
18a782f 
Backport #27839 by @lunny

Fix #23742

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@lunny @KN4CK3R @fuxiaohei
Fix package webhook (go-gitea#27839)
e4bb33e 
Fix go-gitea#23742

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@lunny @KN4CK3R @silverwind
Fix package webhook (go-gitea#27839)
de1a2ea 
Fix go-gitea#23742

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix package webhook lunny/gitea
1 participant
@ptman