Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit File button during PR review #23848

Closed
codetorex opened this issue Mar 31, 2023 · 3 comments · Fixed by #29697
Closed

Edit File button during PR review #23848

codetorex opened this issue Mar 31, 2023 · 3 comments · Fixed by #29697
Labels
topic/pr Issues related to pull requests type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@codetorex
Copy link

Feature Description

We love using Gitea and it would be great that if we could edit files during pull request reviews. As a reviewer I go to "Files Changed" tab on a pull request, and it would be great if there is a button called "Edit File" next to "View File" button. Upon clicking on it could be either;

  • Convert file view in current page (Files Changed tab) to editable one similar to commenting and it will create a commit with changes upon save
  • Show a popup that has editable file in it and that will create a commit with file changes
  • Go to existing edit file page in the source branch of the PR where saving the file will create a commit

This would save time on fixing small typos etc encountered rather than going back and forth between people or pulling the entire branch, changing and pushing :)

Screenshots

No response
@codetorex codetorex added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 31, 2023
@silverwind
Copy link
Member

I think there was some recent work on this.

@lunny
Copy link
Member

lunny commented May 12, 2023

We should have a new mode for changed files review, that is `all changed files will be loaded in the left tree and the right place will only show the chosed file. So that only one file will be displayed in the right panel. Then when click edit button, we can replace the whole patch for this file as an edit box.

@silverwind
Copy link
Member

Actually I think I'm wrong, there was no recent work. I misread the request 😉

@silverwind silverwind added topic/pr Issues related to pull requests and removed theme/review labels May 18, 2023
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Dec 30, 2023
@wetneb
[GITEA] pulls: "Edit File" button in "Files Changed" tab
79c7516 
Closes #1894.
Gitea issue: go-gitea/gitea#23848
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Jan 22, 2024
@wetneb @earl-warren
[GITEA] pulls: "Edit File" button in "Files Changed" tab
35549ff 
Closes #1894.
Gitea issue: go-gitea/gitea#23848

(cherry picked from commit 79c7516)
(cherry picked from commit 58c76aa)
(cherry picked from commit 5bdb3c6)
(cherry picked from commit 94e954c)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Jan 28, 2024
@wetneb @earl-warren
[GITEA] pulls: "Edit File" button in "Files Changed" tab
6a234ab 
Closes #1894.
Gitea issue: go-gitea/gitea#23848

(cherry picked from commit 79c7516)
(cherry picked from commit 58c76aa)
(cherry picked from commit 5bdb3c6)
(cherry picked from commit 94e954c)
(cherry picked from commit 1388e7c)
6543 pushed a commit to 6543-forks/gitea that referenced this issue Feb 26, 2024
@wetneb @earl-warren
[GITEA] pulls: "Edit File" button in "Files Changed" tab
f3b2981 
Closes go-gitea#1894.
Gitea issue: go-gitea#23848

(cherry picked from commit 79c75164ca70937261b1d9a68420ebfdbdcfa4d4)
(cherry picked from commit 58c76aad8f624d7701e3fa6c12264328962cdf58)
(cherry picked from commit 5bdb3c6c53527da23ba76a8289ca6a81c6fcecdf)
(cherry picked from commit 94e954ce2248f14082f0c3071cc076c118c4a791)
(cherry picked from commit 1388e7c7bef7a34018b993c24b34e053849eb93a)
(cherry picked from commit 6a234abff532bfc8806e0cccf8c2d1d8c3e90c24)
@lunny lunny mentioned this issue Mar 26, 2024
Merged
lunny added a commit that referenced this issue Mar 27, 2024
@lunny @wxiaoguang @silverwind
Put an edit file button on pull request files to allow a quick operat…
538790a 
…ion (#29697)

Resolve #23848

This PR put an edit file button on pull request files to allow a quick
edit for a file. After the edit finished, it will return back to the
viewed file position on pull request files tab.

It also use a branch view file link instead of commit link when it's a
non-commit pull request files view.

<img width="1532" alt="image"
src="https://github.com/go-gitea/gitea/assets/81045/3637ca4c-89d5-4621-847b-79702a44f617">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/pr Issues related to pull requests type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put an edit file button on pull request files to allow a quick operation lunny/gitea
3 participants
@lunny @silverwind @codetorex