Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository counter badge like GitHub #24188

Closed
jakob30061 opened this issue Apr 18, 2023 · 7 comments · Fixed by #24205
Closed

Add repository counter badge like GitHub #24188

jakob30061 opened this issue Apr 18, 2023 · 7 comments · Fixed by #24205
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.20.0

Comments

@jakob30061
Copy link
Contributor

Feature Description

After searching for a similar issue, i only could find this one. #19327

I already added the necessary lines, but wasn't sure if a direct PR would be merged, because of this section in CONTRIBUTING.md

Badge is only visible if a repo exists (like "Starred Repositories").
Badge for users and organizations (compare screenshots)

Can I add a PR?

Screenshots

image
image
@jakob30061 jakob30061 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 18, 2023
@yardenshoham
Copy link
Member

open a PR

@yardenshoham
Copy link
Member

make it gray like
image

@jakob30061
Copy link
Contributor Author

make it gray like image

I'm going to change the color of "Starred Repositories" as well, the avoid ui inconsistency
image

@yardenshoham
Copy link
Member

Yes, good idea

@jakob30061
Copy link
Contributor Author

Thanks for the fast responses.

While testing my implementation, i found out that when switching tabs the badges (my new repo badge and the old starred repo badge as well) are shown for /gitea_user?tab=stars, /gitea_user?tab=activity and missing under gitea_user/-/projects and gitea_user/-/packages

The general layout changes a little bit, so maybe it was intentional. Should I include fixes for that as well in the PR?

image

@yardenshoham
Copy link
Member

I think you could do that in another PR. Keep PRs small

@jakob30061 jakob30061 mentioned this issue Apr 19, 2023
Merged
@jakob30061
Copy link
Contributor Author

Thank you for your help @yardenshoham

techknowlogick pushed a commit that referenced this issue Apr 19, 2023
@jakob30061
Add repository counter badge to repository tab (#24205)
52b17bf 
Add a new badge to the repository tab for users and organizations.
The badge is only visible if a repo exists.

Change the badge color of existing "Starred Repositories". (from primary to small)

Closes #24188
@lunny lunny added this to the 1.20.0 milestone Apr 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Add repository counter badge to repository tab jakob30061/gitea
3 participants
@lunny @yardenshoham @jakob30061