Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] User followers page #24418

Closed
appleboy opened this issue Apr 29, 2023 · 1 comment · Fixed by #24428
Closed

[UI] User followers page #24418

appleboy opened this issue Apr 29, 2023 · 1 comment · Fixed by #24428
Labels
type/bug
Milestone
1.20.0

Comments

@appleboy
Copy link
Member

appleboy commented Apr 29, 2023 •
edited
Loading

Description

Find a bug. See the followers page: https://gitea.com/appleboy?tab=followers

Reference PR: #24315

Gitea Version

1.20.0+dev-601-g50133b02b

Can you reproduce the bug on the Gitea demo site?

Yes

Screenshots

Before

image

After

remove max-width: calc(100vw - 64px);

image
@appleboy appleboy added this to the 1.20.0 milestone Apr 29, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 29, 2023 •
edited
Loading

IMO max-width: calc(100vw - 64px); is not wrong in this case.

The root problem is that the old code was wrong.

ui container user-cards : it should not use ui container

@KN4CK3R KN4CK3R mentioned this issue Apr 29, 2023
Merged
silverwind pushed a commit that referenced this issue Apr 29, 2023
@KN4CK3R
Fix user-cards format (#24428)
a18919b 
Fixes #24418
@GiteaBot GiteaBot mentioned this issue Apr 29, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Apr 29, 2023
@KN4CK3R @GiteaBot
Fix user-cards format (go-gitea#24428)
316f08c 
Fixes go-gitea#24418
techknowlogick pushed a commit that referenced this issue Apr 30, 2023
@GiteaBot @KN4CK3R
Fix user-cards format (#24428) (#24431)
7d7ba76 
Backport #24428 by @KN4CK3R

Fixes #24418

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Fix user-cards format KN4CK3R/gitea
3 participants
@appleboy @wxiaoguang @HesterG