Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare commit page UI problem #25825

Closed
yp05327 opened this issue Jul 11, 2023 · 1 comment · Fixed by #26209
Closed

Compare commit page UI problem #25825

yp05327 opened this issue Jul 11, 2023 · 1 comment · Fixed by #26209
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Jul 11, 2023

Description

image

You can confirm this issue in try.gitea.io:
https://try.gitea.io/yp05327/testrepo/compare/7287e11b139eeb913348599efd543baf77b00709..73bc61b468580fd399568cd214bef3acf684bad9

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 11, 2023
@silverwind
Copy link
Member

silverwind commented Jul 11, 2023 •
edited
Loading

Adding gt-whitespace-nowrap to commits-table-right fixes the immediate issue but there is more wrong here, like missing margin on top of commits-table and unknown outcome of the class addition when the other body of commits-table-right renders.

@puni9869 puni9869 mentioned this issue Jul 28, 2023
Merged
silverwind pushed a commit that referenced this issue Jul 29, 2023
@puni9869 @GiteaBot
Fix commit compare style (#26209)
1107425 
as title

Fixes : #25825
Before
<img width="1334" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c54a41b0-39bd-4094-a956-081a8f4128f2">

After change
<img width="1340" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c112d235-6bbe-4bcb-9529-78da3ab0fa14">

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this issue Jul 29, 2023
Merged
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Jul 29, 2023
@puni9869 @GiteaBot
Fix commit compare style (go-gitea#26209)
55bdb6e 
as title

Fixes : go-gitea#25825
Before
<img width="1334" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c54a41b0-39bd-4094-a956-081a8f4128f2">

After change
<img width="1340" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c112d235-6bbe-4bcb-9529-78da3ab0fa14">

Co-authored-by: Giteabot <teabot@gitea.io>
silverwind pushed a commit that referenced this issue Jul 29, 2023
@GiteaBot @puni9869
Fix commit compare style (#26209) (#26226)
81d3dc1 
Backport #26209 by @puni9869

as title

Fixes : #25825
Before
<img width="1334" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c54a41b0-39bd-4094-a956-081a8f4128f2">

After change
<img width="1340" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c112d235-6bbe-4bcb-9529-78da3ab0fa14">

Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix commit compare style puni9869/gitea
3 participants
@lunny @silverwind @yp05327