Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.txt vs. README.md #2701

Closed
pmorjan opened this issue Oct 14, 2017 · 7 comments · Fixed by #2705
Closed

README.txt vs. README.md #2701

pmorjan opened this issue Oct 14, 2017 · 7 comments · Fixed by #2705
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change
Milestone
1.3.0

Comments

@pmorjan
Copy link

pmorjan commented Oct 14, 2017

Gitea 1.2.0

Description

A plain text README.txt instead of a README.md file in the repository root directory is rendered as Markdown and displayed on the main repository web site.
This can lead to a broken layout because multiple white space characters used for indentation or in ASCII art are replaced by single blancs. Also the font family for plain text should be monospace.

It would be nice if Gitea would render a plain text README.txt using a monospace font without any modifications.
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 14, 2017
@lafriks lafriks added this to the 1.x.x milestone Oct 14, 2017
@strk
Copy link
Member

strk commented Oct 14, 2017 via email

@lunny
Copy link
Member

lunny commented Oct 14, 2017

@lafriks I think strk is right. I will check this and send a PR to fix that.

@lafriks lafriks added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Oct 14, 2017
@lunny lunny modified the milestones: 1.x.x, 1.3.0 Oct 15, 2017
@lunny lunny mentioned this issue Oct 15, 2017
Merged
@pmorjan
Copy link
Author

pmorjan commented Oct 16, 2017

Thanks for the very quick response!
However I think the PR doesn't fix the issue. At least not how I wanted it.
I created an example:
https://try.gitea.io/pmorjan/issue2701
I would prefer the rendering to be similar to the view in the editor:
https://try.gitea.io/pmorjan/issue2701/_edit/master/README.txt

@Morlinest
Copy link
Member

@pmorjan Can't open your second link.

@pmorjan
Copy link
Author

pmorjan commented Oct 16, 2017

sorry, hop this renders correctly

     /\_____/\
     |  o o  |
    __\__^__/__
   (__/     \__)
    _|   .   |_
   (__\_____/__)

@Morlinest
Copy link
Member

@pmorjan yes, I get it now.

@lafriks
Copy link
Member

lafriks commented Oct 16, 2017

@pmorjan please open for that new issue as bug was fixed:
https://try.gitea.io/lafriks/issue2701

monospace font for text still needs to be implemented

@RazvanFarte RazvanFarte mentioned this issue Aug 26, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Fix plain readme didn't render correctly on repo home page lunny/gitea
5 participants
@lunny @lafriks @strk @pmorjan @Morlinest