Fix plain readme didn't render correctly on repo home page #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
force-pushed
the
lunny/fix_plain_readme
branch
from
f8498bb to
1a452f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2705 +/- ##
=======================================
Coverage 26.95% 26.95%
=======================================
Files 87 87
Lines 17301 17301
=======================================
Hits 4664 4664
Misses 11957 11957
Partials 680 680Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
@lunny I don't know why but integration tests fail |
|
@lafriks I think I find the problem, sent another commit. |
Morlinest
suggested changes
Oct 15, 2017
routers/repo/view.go
Outdated
| @@ -93,6 +93,7 @@ func renderDirectory(ctx *context.Context, treeLink string) { | |||
| if isTextFile { | |||
| d, _ := ioutil.ReadAll(dataRc) | |||
| buf = append(buf, d...) | |||
| ctx.Data["IsRenderedHTML"] = true | |||
| newbuf := markup.Render(readmeFile.Name(), buf, treeLink, ctx.Repo.Repository.ComposeMetas()) | |||
| if newbuf != nil { | |||
| ctx.Data["IsMarkup"] = true | |||
There was a problem hiding this comment.
ctx.Data["IsMarkup"] is not needed anymore?
lunny
force-pushed
the
lunny/fix_plain_readme
branch
from
b795e7d to
dee2f54
Compare
|
@Morlinest done. |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Oct 16, 2017
…2705) * fix plain readme didn't render correctly on repo home page * fix missing render * remove unused template variables
appleboy
pushed a commit
that referenced
this pull request
Oct 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will fix #2701