Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Safari Pinned Tab Icons #2753

Closed
1 of 3 tasks
brinsche opened this issue Oct 20, 2017 · 0 comments · Fixed by #2799
Closed
1 of 3 tasks

Support Safari Pinned Tab Icons #2753

brinsche opened this issue Oct 20, 2017 · 0 comments · Fixed by #2799
Labels
topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.3.0

Comments

@brinsche
Copy link

brinsche commented Oct 20, 2017 •
edited
Loading

  • Gitea version (or commit ref): 1.2.1
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

I'd love to see support for Safari Pinned Tab Icons as described here: https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/pinnedTabs/pinnedTabs.html

The main hurdle is probably the generation of a suitable .svg icon.

Screenshots

screen shot 2017-10-20 at 23 14 53

On the left the pinned tab of github.com, right try.gitea.io
@lunny lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Oct 21, 2017
@lunny lunny added this to the 1.x.x milestone Oct 21, 2017
brinsche added a commit to brinsche/gitea that referenced this issue Oct 28, 2017
@brinsche
Add Safari pinned tab icon
bc2b4fb 
Closes go-gitea#2753

Signed-off-by: Bastian Rinsche <bastian.rinsche@gmail.com>
@brinsche brinsche mentioned this issue Oct 28, 2017
Merged
appleboy pushed a commit that referenced this issue Oct 29, 2017
@memorion @appleboy
Add Safari pinned tab icon (#2799)
638509b 
Closes #2753

Signed-off-by: Bastian Rinsche <bastian.rinsche@gmail.com>
@lunny lunny modified the milestones: 1.x.x, 1.3.0 Oct 29, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Add Safari pinned tab icon brinsche/gitea
2 participants
@lunny @brinsche