Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The git blame view fails to display the majority of its "prior to change" markers #28280

Closed
jessey-git opened this issue Nov 29, 2023 · 2 comments · Fixed by #28306
Closed

The git blame view fails to display the majority of its "prior to change" markers #28280

jessey-git opened this issue Nov 29, 2023 · 2 comments · Fixed by #28306
Labels
Milestone

Comments

@jessey-git
Copy link

Description

When viewing a file's Blame history, you are presented with the ability to view the file "prior to" commits affecting various lines. Gitea is enabling this feature in a very sporadic sense and often not at all.

Compare these 2 blames on the same file, one in Gitea and one on GitHub:
Gitea: https://projects.blender.org/blender/blender/blame/branch/main/source/blender/editors/interface/interface_ops.cc
GitHub: https://github.com/blender/blender/blame/main/source/blender/editors/interface/interface_ops.cc

Gitea Version

1.21.1+406-ga09b13b6d

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Own build.

Database

SQLite

@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 29, 2023

The problem are moved files. The blame breaks / doesn't show the marker if the file does not exist in the parent commit. Github links to the correct filename at that commit.

For example Gitea does not show the marker here because there is no interface_ops.cc in the parent:
grafik
Github resolves the old name:
grafik

Edit: Found a solution, will send a fix soon.

@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 30, 2023

Fixed with #28306

@lunny lunny added this to the 1.21.2 milestone Dec 1, 2023
lafriks pushed a commit that referenced this issue Dec 1, 2023
Fixes #28280

Reads the `previous` info from the `git blame` output instead of
calculating it afterwards.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 1, 2023
Fixes go-gitea#28280

Reads the `previous` info from the `git blame` output instead of
calculating it afterwards.
KN4CK3R added a commit that referenced this issue Dec 1, 2023
Backport #28306 by @KN4CK3R

Fixes #28280

Reads the `previous` info from the `git blame` output instead of
calculating it afterwards.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
pangliang pushed a commit to pangliang/gitea that referenced this issue Dec 5, 2023
Fixes go-gitea#28280

Reads the `previous` info from the `git blame` output instead of
calculating it afterwards.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
Fixes go-gitea#28280

Reads the `previous` info from the `git blame` output instead of
calculating it afterwards.
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
Fixes go-gitea#28280

Reads the `previous` info from the `git blame` output instead of
calculating it afterwards.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants