Uploaded artifacts should be overwritten

[hakito]

Description

According to github documentation artifacts sharing the same name should be overwritten.

Gitea seems to discard/ignore the second upload. Here is an example workflow:

name: Uploads
on:
  - push

jobs:
  first:
    name: upload first
    runs-on: windows
    steps:
      - run: echo "first" > actual
      - uses: actions/upload-artifact@v3
        with:
          name: actual
          path: actual
  second:
    needs: [first]
    name: upload second
    runs-on: windows
    steps:
      - run: echo "second" > actual
      - uses: actions/upload-artifact@v3
        with:
          name: actual
          path: actual
  verify:
    needs: [second]
    name: Verify contents
    runs-on: windows
    steps:
      - name: Fetch Integration Tests from Build
        uses: actions/download-artifact@v3
        with:
          name: actual
      - run: echo "second" > expected
      - run: fc.exe expected actual

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea/gitea:latest

Database

MySQL/MariaDB

[hakito]

Side note:

We are currently migrating our build system to gitea, and this could have become a critical problem.

We first build our software and upload the binaries. In a second job we overwrite the encrypted binaries. If I hadn't checked manually, the unencrypted version would be shipped!

[lunny]

Can you run that on github successfully?

[hakito]

Yes https://github.com/hakito/Activity/actions/runs/7274027094/job/19819139031

Only adapted the label name to Windows

[hakito]

FYI - Also when re-running a job it keeps the old artifacts.

[lunny]

FYI - Also when re-running a job it keeps the old artifacts.

Wow, so this is a bug?

[hakito]

Well I would consider it a bug if I successfully upload an artifact (with re-run), but the artifact is not the uploaded. I made a very simple example do demonstrate it:

on: [push]
jobs:
  Timestamp:
    runs-on: [windows]
    steps:
      - run: get-date -Format "o" > timestamp.txt
      - run: cat timestamp.txt
      - uses: actions/upload-artifact@v3
        with:
            path: timestamp.txt           

Simply run the job a 2nd time manually. After the 2nd run the output of cat timestamp.txt in web interface is:

2023-12-29T08:17:55.7576776+01:00

But the content of the downloaded artifact is:

2023-12-29T08:17:03.1341990+01:00

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines