Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badges API test failure #29602

Closed
techknowlogick opened this issue Mar 5, 2024 · 1 comment · Fixed by #29254
Closed

Badges API test failure #29602

techknowlogick opened this issue Mar 5, 2024 · 1 comment · Fixed by #29254
Labels
type/bug type/testing

Comments

@techknowlogick
Copy link
Member 

          Due to the bug of CI/test, the test failures are never caught:

image

Originally posted by @wxiaoguang in #23106 (comment)
@silverwind

This comment was marked as off-topic.

Sign in to view
@lunny lunny mentioned this issue Mar 5, 2024
Merged
6543 pushed a commit that referenced this issue Mar 7, 2024
@lunny
Fix bug hidden on CI and make ci failed if tests failure (#29254)
4527748 
The tests on migration tests failed but CI reports successfully


https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migration v283 and also the CI hidden
behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But 

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

This also fix #29602
lunny added a commit to lunny/gitea that referenced this issue Mar 8, 2024
@lunny
Fix bug hidden on CI and make ci failed if tests failure (go-gitea#29254
97cb675 
)

The tests on migration tests failed but CI reports successfully

https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migration v283 and also the CI hidden
behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

This also fix go-gitea#29602
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug hidden on CI and make ci failed if tests failure lunny/gitea
3 participants
@lunny @silverwind @techknowlogick