Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged PR should hide re-request review button #29965

Closed
yp05327 opened this issue Mar 21, 2024 · 0 comments · Fixed by #30065
Closed

Merged PR should hide re-request review button #29965

yp05327 opened this issue Mar 21, 2024 · 0 comments · Fixed by #30065
Labels
type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Mar 21, 2024 •
edited
Loading

Description

After PR merged, I can still request or remove review request.
image
https://gitea.com/gitea/gitea-docusaurus/pulls/92

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.com

Database

None
@kemzeb kemzeb mentioned this issue Mar 25, 2024
Merged
lunny pushed a commit that referenced this issue Mar 28, 2024
@kemzeb
Prevent re-review and dismiss review actions on closed and merged PRs (…
242b331 
…#30065)

Resolves #29965.

---
Manually tested this by:
- Following the
[installation](https://docs.gitea.com/next/installation/install-with-docker#basics)
guide (but built a local Docker image instead)
- Creating 2 users, one who is the `Owner` of a newly-created repository
and the other a `Collaborator`
- Had the `Collaborator` create a PR that the `Owner` reviews
- `Collaborator` resolves conversation and `Owner` merges PR

And with this change we see that we can no longer see re-request review
button for the `Owner`:

<img width="1351" alt="Screenshot 2024-03-25 at 12 39 18 AM"
src="https://github.com/go-gitea/gitea/assets/60799661/bcd9c579-3cf7-474f-a51e-b436fe1a39a4">
@yp05327 yp05327 mentioned this issue Apr 24, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent re-review and dismiss review actions on closed and merged PRs kemzeb/gitea
1 participant
@yp05327