Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When adding code comment the note suggesting markdown with octicon doesn't show the octicon #30082

Closed
yardenshoham opened this issue Mar 25, 2024 · 3 comments · Fixed by #30086
Closed

When adding code comment the note suggesting markdown with octicon doesn't show the octicon #30082

yardenshoham opened this issue Mar 25, 2024 · 3 comments · Fixed by #30086
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yardenshoham
Copy link
Member

Description

No response

Screenshots

image

Gitea Version

current main

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

.
@yardenshoham yardenshoham added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 25, 2024
@silverwind
Copy link
Member

Noticed a similar issue on devtest page http://localhost:3000/devtest/flex-list:

image

@silverwind
Copy link
Member

It seems those octicons do not exist, or at least markup is markdown:

https://primer.github.io/octicons/

@silverwind
Copy link
Member

The first case was regressed in 6400668.

@silverwind silverwind mentioned this issue Mar 25, 2024
Merged
silverwind added a commit that referenced this issue Mar 26, 2024
@silverwind
Add svg linter and fix incorrect svgs (#30086)
2ab5f05 
Fixes #30082.

Adds a new linter that searches for non-existant SVG images in
templates. Output before the fix was:

```
$ make lint-templates
SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl
SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl
SVG "octicon-markup" not found, used in templates/repo/diff/comment_form.tmpl
make: *** [Makefile:438: lint-templates] Error 1
```

<img width="306" alt="Screenshot 2024-03-25 at 23 31 05"
src="https://github.com/go-gitea/gitea/assets/115237/1052d1a9-bfec-4d5a-9cae-f895f78f7c93">
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 30, 2024
@silverwind @earl-warren
Add svg linter and fix incorrect svgs (#30086)
72a3a6f 
Fixes go-gitea/gitea#30082.

Adds a new linter that searches for non-existant SVG images in
templates. Output before the fix was:

```
$ make lint-templates
SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl
SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl
SVG "octicon-markup" not found, used in templates/repo/diff/comment_form.tmpl
make: *** [Makefile:438: lint-templates] Error 1
```

<img width="306" alt="Screenshot 2024-03-25 at 23 31 05"
src="https://github.com/go-gitea/gitea/assets/115237/1052d1a9-bfec-4d5a-9cae-f895f78f7c93">

(cherry picked from commit 2ab5f05f40d93224f73e211e84de50a88a6ecf03)

Conflicts:
	.github/workflows/files-changed.yml
	.github/workflows/pull-compliance.yml
	do not exist in Forgejo and the Forgejo workflows
	already contain the changes
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add svg linter and fix incorrect svgs silverwind/gitea
2 participants
@silverwind @yardenshoham