Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake test: TestWorkerPoolQueueWorkerIdleReset #30643

Closed
silverwind opened this issue Apr 22, 2024 · 1 comment · Fixed by #30646
Closed

Flake test: TestWorkerPoolQueueWorkerIdleReset #30643

silverwind opened this issue Apr 22, 2024 · 1 comment · Fixed by #30646
Labels
type/testing

Comments

@silverwind
Copy link
Member

silverwind commented Apr 22, 2024 •
edited
Loading

Seen here:

--- FAIL: TestWorkerPoolQueueWorkerIdleReset (0.51s)
    workerqueue_test.go:270: 
          Error Trace:  /home/runner/work/gitea/gitea/modules/queue/workerqueue_test.go:270
          Error:        Not equal: 
                        expected: int(2)
                        actual  : int32(3)
          Test:         TestWorkerPoolQueueWorkerIdleReset
FAIL
@silverwind silverwind added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/testing and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 22, 2024
@wxiaoguang wxiaoguang mentioned this issue Apr 22, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Fix queue test #30646

wxiaoguang added a commit that referenced this issue Apr 22, 2024
@wxiaoguang
Fix queue test (#30646)
e610395 
Fix #30643

The old test code is not stable due to the data-race described in the
TODO added at that time.

Make it stable, and remove a debug-only field from old test code.
wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Apr 23, 2024
@wxiaoguang
Fix queue test (go-gitea#30646)
a34d77d 
Fix go-gitea#30643

The old test code is not stable due to the data-race described in the
TODO added at that time.

Make it stable, and remove a debug-only field from old test code.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix queue test wxiaoguang/gitea
2 participants
@silverwind @wxiaoguang