Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit hashes are different sizes and overflow on homepage #30919

Closed
JanRomero opened this issue May 9, 2024 · 2 comments · Fixed by #30920
Closed

Commit hashes are different sizes and overflow on homepage #30919

JanRomero opened this issue May 9, 2024 · 2 comments · Fixed by #30920
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@JanRomero
Copy link

JanRomero commented May 9, 2024 •
edited
Loading

Description

Sorry if this is a dupe, I searched for everything that came to mind...

After upgrading to 1.22.0-rc1 the homepage has this problem with commit ids both in Firefox and Edge. This only happens for long commit messages and is reproducible on try.gitea.io if you can find or fake a long message. For example, go to Lunny’s activity and use dev tools to make one of the commit messages longer.

It seems to be fixed by adding flex-shrink: 100; to the commit message <span>, but not sure if that will cause problems elsewhere. I’ve only played around in the browser tools.

Thank you!

Screenshots

grafik

Gitea Version

1.22.0-rc1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Firefox and MsEdge latest
@JanRomero JanRomero added topic/ui Change the appearance of the Gitea UI type/bug labels May 9, 2024
@wxiaoguang wxiaoguang mentioned this issue May 9, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Fix some UI regressions for commit list #30920

@JanRomero
Copy link
Author

Awesome, thanks! I forgot you could set flex-shrink to 0, lol

wxiaoguang added a commit that referenced this issue May 10, 2024
@wxiaoguang @silverwind
Fix some UI regressions for commit list (#30920)
080486e 
Close #30919

---------

Co-authored-by: silverwind <me@silverwind.io>
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 10, 2024
@wxiaoguang @silverwind @GiteaBot
Fix some UI regressions for commit list (go-gitea#30920)
7b6ba1d 
Close go-gitea#30919

---------

Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot mentioned this issue May 10, 2024
Merged
wxiaoguang added a commit that referenced this issue May 10, 2024
@GiteaBot @wxiaoguang @silverwind
Fix some UI regressions for commit list (#30920) (#30937)
94c5a30 
Backport #30920 by wxiaoguang

Close #30919

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some UI regressions for commit list wxiaoguang/gitea
2 participants
@wxiaoguang @JanRomero