Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention completion should complete with people outside the organisation #3443

Open
kolaente opened this issue Feb 1, 2018 · 11 comments
Open
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@kolaente
Copy link
Member

kolaente commented Feb 1, 2018

When mentioning someone, the mention completion only mentions people inside my own org (or only the owner, if I'm in a user repository). Thats probaly fine for private repos, but for public ones?

Ideally, it should autocomplete
a) everyone, if the current issue is in a public repo
b) only people with access to the repo, if its a private one. This would include team members of an organisation (I think actually everyone within an organisation who is in a team with read access + issuetracker/pr) and added members via settings (because user repos can also add members for collaboration).

\cc @harryxu

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 1, 2018
@harryxu
Copy link
Contributor

harryxu commented Feb 2, 2018

In #3136 , I fetch people list from current org's Assignees.

May be we should add an api to fetch any people to Mention? But Im not good at go lang. Can anyone help to implement this api?

@bkcsoft
Copy link
Member

bkcsoft commented Feb 10, 2018

You can sort the list by relevance. First people in the Issue/PR, then Project members, then Organization members, then Globally. WDYT?

EDIT: Forgot "participants" as first prio.

@bkcsoft
Copy link
Member

bkcsoft commented Feb 10, 2018

Using participants as the first set can potentially save on AJAX-calls as well, since we already have the participant list loaded in the page ;)

@stale
Copy link

stale bot commented Feb 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 8, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 8, 2019
@worthy7
Copy link

worthy7 commented Sep 4, 2019

Hey everyone,

Just started using Gitea a bit more, and wanted to reference my boss in a PR but couldn't.
It doesn't make sense to restrict it to teams, because what about individual repositories? Then there is literally no use for the mention feature because there will never be anyone.

Needs to just copy the github functionality, let the user decide who they want to mention without restrictions.
For massive companies, people with the same last name etc (or username) perhaps just add some kind of (Project/Organization/team) tags to the mention dropdown, so it's dead clear.

Cheers

@worthy7
Copy link

worthy7 commented Sep 5, 2019

image

I cannot even mention someone when I am the owner. This is really a bug and needs fixing please. This means that owners cannot ever mention anyone who isn't an owner - even if they are in another team too!

@harryxu Could you perhaps just change your code so that it includes all teams in the dropdown and make a quick PR?

@lunny
Copy link
Member

lunny commented Sep 5, 2019

I think maybe we could have an option to allow mention any people on that site on app.ini or not.

@worthy7
Copy link

worthy7 commented Oct 5, 2019

Looking at this again, assuming the system is not multi-tenant, then it should just work like Github, probably showing everyone, and proritizing based on... 1) The contexts participants (issue/PR), 2) Everyone in the Org (if applicable) and 3) everyone.

I don't see any reason why it needs to be limited to teams in the first place - it's not a secret who the other users are

@mdbergmann
Copy link

This is also a problem in our company where we installed Gitea.
Would be great if this could be fixed.

@lunny
Copy link
Member

lunny commented Aug 13, 2020

I think we can do that according if the repository is a public one or a private one.

  • For public repository, you can mention anyone on this Gitea instance
  • For limit/private repositories, you can mention those who have the read permissions on this repository

@iarepandemonium
Copy link

Adding on this, my team has people who review pull requests without exclusive access to the code, and it would be nice to mention anyone within the organization because I have people assigned as reviewers who only look at the code in the PR not in the whole repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

8 participants