Mention completion for issue editor. #3136
Conversation
lafriks
added
the
type/feature
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
+ Coverage 34.57% 34.73% +0.16%
==========================================
Files 276 276
Lines 39945 39948 +3
==========================================
+ Hits 13809 13877 +68
+ Misses 24155 24076 -79
- Partials 1981 1995 +14
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
Can you convert tribute css to less file and include into main gitea css? Then there would be no need for additional css include |
| @@ -351,6 +351,7 @@ func NewIssue(ctx *context.Context) { | |||
| ctx.Data["PageIsIssueList"] = true | |||
| ctx.Data["RequireHighlightJS"] = true | |||
| ctx.Data["RequireSimpleMDE"] = true | |||
| ctx.Data["RequireTribute"] = true | |||
There was a problem hiding this comment.
I believe we also should require tribute in CompareAndPullRequest
templates/base/footer.tmpl
Outdated
| @@ -58,6 +58,33 @@ | |||
| {{if .RequireDropzone}} | |||
| <script src="{{AppSubUrl}}/vendor/plugins/dropzone/dropzone.js"></script> | |||
| {{end}} | |||
|
|
|||
There was a problem hiding this comment.
nit: delete blank line for consistency
templates/base/footer.tmpl
Outdated
| ], | ||
| noMatchTemplate: function () { return null }, | ||
| menuItemTemplate: function (item) { | ||
| var user = item.original; |
There was a problem hiding this comment.
nit: should the function body (lines 76-81) be indented?
|
@lafriks I will check out later, but I see other JS plugin's css also included by this way. |
|
@ethantkoenig Done. |
|
@harryxu yes I know, this one has small css so it was just an idea, it's totally not required and not blocking this PR |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Mention completion on issue editor.
@mentionengine from tribute.Demo:
New issue:
View/Edit issue:
