Emoji Autocomplete

[modmew8]

Implements #3316.

Uses the same plugin (tribute) and the same style as #3136.

To prevent performance issues, the resultset is limited to 6 elements (substring search). The emojilist is taken from the emojify plugin directly in javascript (emojify.emojiNames).

The image path is crafted using src="{{AppSubUrl}}/vendor/plugins/emojify/images/' + emojiname + '.png".

[codecov-io]

Codecov Report

Merging #3433 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
- Coverage    35.6%   35.56%   -0.04%     
==========================================
  Files         281      281              
  Lines       40586    40586              
==========================================
- Hits        14452    14436      -16     
- Misses      23997    24011      +14     
- Partials     2137     2139       +2

Impacted Files	Coverage Δ
modules/indexer/indexer.go	70% <0%> (-7.5%)	⬇️
models/repo_indexer.go	41.15% <0%> (-4.87%)	⬇️
models/repo_list.go	65.62% <0%> (-1.57%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62ce2e...96d2f7f. Read the comment docs.

[lafriks]

Vendor css should not be changed. Instead create new rule in gitea style less file

[modmew8]

The vendor css has apparently already been altered, if you take a look at the original repo:
https://github.com/zurb/tribute/blob/master/dist/tribute.css

Then we should reset it to default and transport the changes been done to the gitea style less file as well.

[kolaente]

Is there a reason to not put this in /public/js/index.js?

[lafriks]

@kolaente it can't be put (at least currently) in index.js as it has server-side condition check if this should be included so such refactoring would probably be better done in different PR

[modmew8]

I tried putting it to /public/js/index.js, and limited the initialization of tribute to a condition, wether an element with id content is available.

But I think it is much cleaner, if the emojiTribute is only initialized when the page requiring it is loaded.

[kolaente]

oh ok I see...

[strk]

@go-gitea/maintainers is there any good reason why this css file should be minified ? It's hard to read any change like this...

[ethantkoenig]

@strk Changes should be made to .less files, not the css directly, so the goal is to not have to read the css changes in the first place.

[thehowl]

... did you seriously try to read the minified code? 😄

[strk]

On Tue, Jan 30, 2018 at 06:24:03PM +0000, Ethan Koenig wrote: @strk Changes should be made to `.less` files, not the css directly, so the goal is to not have to read the css changes in the first place.

Should the css be removed from repository then ?

[techknowlogick]

@strk no, because then that adds an additional requirement for users if they want to build the project.

[lafriks]

You can just use j < Math.min(array.length, 5) and than you don't need counter variable and condition below with break.

[daviian]

I guess there should be 6 elements in the data array, which is not always the case in a loop to 5 because of the if condition.
Instead of the counter the break could be done by condition data.length > 5?

[modmew8]

Yes, this loop is used to limit the amount of results to a maximum of 6 - but traverses all emojiNames using j. Removing the counter and replacing the condition with data.length >5 looks much better to me. Thanks @daviian