Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce sql query times in retrieveFeeds #3547

Merged
merged 2 commits into from
Feb 21, 2018
Merged

refactor: reduce sql query times in retrieveFeeds #3547

merged 2 commits into from
Feb 21, 2018

Conversation

appleboy
Copy link
Member

  1. remove unused repo cache
  2. Add action list struct to reduce sql query times.

@appleboy appleboy added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 20, 2018
@appleboy appleboy added this to the 1.5.0 milestone Feb 20, 2018
@codecov-io
Copy link

codecov-io commented Feb 20, 2018 •
edited
Loading

Codecov Report

Merging #3547 into master will increase coverage by 0.05%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3547      +/-   ##
==========================================
+ Coverage   35.72%   35.78%   +0.05%     
==========================================
  Files         284      285       +1     
  Lines       40792    40841      +49     
==========================================
+ Hits        14574    14613      +39     
- Misses      24055    24061       +6     
- Partials     2163     2167       +4
Impacted Files Coverage Δ
models/action.go 64.33% <25%> (-0.78%) ⬇️
models/action_list.go 73.33% <73.33%> (ø)
routers/user/home.go 40.94% <75%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27d720...631f7c5. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2018
@appleboy appleboy changed the title refactor: reduce sql query in retrieveFeeds refactor: reduce sql query times in retrieveFeeds Feb 20, 2018
@appleboy appleboy added the type/enhancement An improvement of existing functionality label Feb 20, 2018
@lunny
Copy link
Member

lunny commented Feb 21, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 21, 2018
@appleboy appleboy modified the milestones: 1.5.0, 1.4.0 Feb 21, 2018
@appleboy
Copy link
Member Author

change milestones to 1.4.0

@lafriks lafriks modified the milestones: 1.4.0, 1.5.0 Feb 21, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2018
@appleboy appleboy merged commit 04b3e8c into go-gitea:master Feb 21, 2018
@appleboy appleboy deleted the improve2 branch February 21, 2018 10:55
@lafriks
Copy link
Member

lafriks commented Feb 21, 2018

@appleboy please backport to 1.4 branch

@appleboy appleboy restored the improve2 branch February 21, 2018 13:54
@appleboy appleboy mentioned this pull request Feb 21, 2018
Merged
@appleboy
Copy link
Member Author

@lafriks See #3554

@appleboy appleboy deleted the improve2 branch February 21, 2018 13:59
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Apr 11, 2018
aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018
@aswild
Merge tag 'v1.5.0-rc1' into wild/v1.5
9b336e6 
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@appleboy @codecov-io @lunny @lafriks @tboerger @delvh