Global code search support #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
Codecov Report
@@ Coverage Diff @@
## master #3664 +/- ##
==========================================
- Coverage 35.86% 35.79% -0.08%
==========================================
Files 287 287
Lines 41359 41489 +130
==========================================
+ Hits 14835 14852 +17
- Misses 24336 24449 +113
Partials 2188 2188
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lafriks
approved these changes
Mar 13, 2018
tboerger
added
lgtm/need 1
sapk
approved these changes
Mar 13, 2018
tboerger
added
lgtm/done
|
Thank you for this wonderful functionality guys. Can you release it on 1.4.0? |
|
@giudon 1.4.0 is already release candidate that means that no features will be added. |
jonasfranz
suggested changes
Mar 13, 2018
options/locale/locale_en-US.ini
Outdated
| repo_no_results = No matching repositories have been found. | ||
| user_no_results = No matching users have been found. | ||
| org_no_results = No matching organizations have been found. | ||
| code_no_results = No matching code have been found. |
There was a problem hiding this comment.
„code have been found“ should be changed to „code has been changed“
There was a problem hiding this comment.
Maybe I should use No matching codes have been found.
There was a problem hiding this comment.
@JonasFranzDEV @lafriks done.
models/repo_list.go
Outdated
| @@ -249,3 +249,28 @@ func SearchRepositoryByName(opts *SearchRepoOptions) (RepositoryList, int64, err | |||
|
|
|||
| return repos, count, nil | |||
| } | |||
|
|
|||
| // FindUserAccessiableRepoIDs find all accessiable repositories' ID by user's id | |||
| func FindUserAccessiableRepoIDs(userID int64) ([]int64, error) { | |||
There was a problem hiding this comment.
does this include organization repos that could be accessed by the user?
There was a problem hiding this comment.
@JonasFranzDEV yes, included.
@mbger done.
|
And I also add the UnitTypeCode check when login user is not admin. |
appleboy
approved these changes
Mar 14, 2018
jonasfranz
approved these changes
Mar 16, 2018
sapk
approved these changes
Mar 16, 2018
aswild
added a commit
to aswild/gitea
that referenced
this pull request
Jul 6, 2018
* SECURITY * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353) * Do not allow to reuse TOTP passcode (go-gitea#3878) * FEATURE * Add cli commands to regen hooks & keys (go-gitea#3979) * Add support for FIDO U2F (go-gitea#3971) * Added user language setting (go-gitea#3875) * LDAP Public SSH Keys synchronization (go-gitea#1844) * Add topic support (go-gitea#3711) * Multiple assignees (go-gitea#3705) * Add protected branch whitelists for merging (go-gitea#3689) * Global code search support (go-gitea#3664) * Add label descriptions (go-gitea#3662) * Add issue search via API (go-gitea#3612) * Add repository setting to enable/disable health checks (go-gitea#3607) * Emoji Autocomplete (go-gitea#3433) * Implements generator cli for secrets (go-gitea#3531) * ENHANCEMENT * Add more webhooks support and refactor webhook templates directory (go-gitea#3929) * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910) * Add option to use paged LDAP search when synchronizing users (go-gitea#3895) * Symlink icons (go-gitea#1416) * Improve release page UI (go-gitea#3693) * Add admin dashboard option to run health checks (go-gitea#3606) * Add branch link in branch list (go-gitea#3576) * Reduce sql query times in retrieveFeeds (go-gitea#3547) * Option to enable or disable swagger endpoints (go-gitea#3502) * Add missing licenses (go-gitea#3497) * Reduce repo indexer disk usage (go-gitea#3452) * Enable caching on assets and avatars (go-gitea#3376) * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969) * Add Environment Variables to Docker template (go-gitea#4012) * LFS: make HTTP auth period configurable (go-gitea#4035) * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184) * Refactor User Settings sections (go-gitea#3900) * Allow square brackets in external issue patterns (go-gitea#3408) * Add Attachment API (go-gitea#3478) * Add EnableTimetracking option to app settings (go-gitea#3719) * Add config option to enable or disable log executed SQL (go-gitea#3726) * Shows total tracked time in issue and milestone list (go-gitea#3341) * TRANSLATION * Improve English grammar and consistency (go-gitea#3614) * DEPLOYMENT * Allow Gitea to run as different USER in Docker (go-gitea#3961) * Provide compressed release binaries (go-gitea#3991) * Sign release binaries (go-gitea#4188)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a code search UI on explore. When indexer is enabled, both guest user and login user could use the feature. Guest user will only search public codes and login user could also search private codes he could access.
