Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji autocomplete #3316

Closed
kolaente opened this issue Jan 7, 2018 · 11 comments
Closed

Emoji autocomplete #3316

kolaente opened this issue Jan 7, 2018 · 11 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@kolaente
Copy link
Member

kolaente commented Jan 7, 2018

I know, this is very low priority.

It would be nice if we could have autocompletion for emojis in issue comments, much like Github or Discord do: You start typing : and it opens up a list with emojis to choose from.

This is probably related to #2456, I think the implementation would be very similar.

@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 7, 2018
@lunny
Copy link
Member

lunny commented Jan 7, 2018

#2456 has been resolved by #3136. Maybe someone could send another similar with #3136 to resolve this.

@lunny lunny added this to the 1.x.x milestone Jan 7, 2018
@modmew8
Copy link
Contributor

modmew8 commented Jan 29, 2018

I'm currently working on this:

emojiautocomplete

Any suggestions how it should be visualized? To keep previewing the emojis performant, I limited the results to 6 elements - using substring search in the emoji list (because tributejs would start listing ALL emojis, resulting in performance issues).

Datasource is taken from emojify directly, so updating emojify is sufficient to have the autocomplete up to date. Its entirely on the clientside.

@lafriks
Copy link
Member

lafriks commented Jan 29, 2018

I think it would be better if picture would be first and only than name

@modmew8
Copy link
Contributor

modmew8 commented Jan 29, 2018

How about this?

emojilist

Requires a small change in the css, but won't break and uses the same style like #3136.

@kolaente
Copy link
Member Author

I like the second one better. Needs maybe some tweaking, but is far better than the first one.

@strk
Copy link
Member

strk commented Jan 30, 2018 via email

@modmew8
Copy link
Contributor

modmew8 commented Jan 30, 2018

@strk I understand your concerns. GitHub starts the lookup after typing a single colon, if there is a blank before the colon. Tributejs does the same - so there is no call for typing bla: - but for bla :.

I accomplished to make tribute start the lookup after the first character is typed after the colon - do we want that?

Another way would be to make the initial lookup return the emojilist we are using as feedback reaction emojis:
Since they are already loaded and there are no additional ajax calls.
My fault, does not.

@strk
Copy link
Member

strk commented Jan 30, 2018 via email

@thehowl
Copy link
Contributor

thehowl commented Jan 30, 2018

That seems to be pretty much what he did (bringing attention to the image, we can see that the previous cat shortcode is not converted into 🐱 but stays :cat:)

image

@modmew8
Copy link
Contributor

modmew8 commented Jan 31, 2018

Demonstration:
emoji

@lafriks lafriks modified the milestones: 1.x.x, 1.5.0 Jan 31, 2018
@kolaente
Copy link
Member Author

Closed because merged with #3433

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

6 participants